From: Teng Long <dyroneteng@gmail.com>
To: gitster@pobox.com
Cc: dyroneteng@gmail.com, git@vger.kernel.org
Subject: Re: [PATCH v1 1/1] list-objects.c: traverse_trees_and_blobs: rename and tree-wide
Date: Thu, 12 Aug 2021 15:54:15 +0800 [thread overview]
Message-ID: <20210812075415.5114-1-dyroneteng@gmail.com> (raw)
In-Reply-To: <xmqqsfzf980v.fsf@gitster.g>
>> Sorry but I do not quite get the " and tree-wide" part of the title.
I may have some misunderstandings about "tree-wide".
Sorry, it will be resolved in the next patch.
>>s/trees_and_blobs/non_commits/ will result in a name that is much
>>shorter and to the point, I think.
Agree and thanks for explanation.
Will follow your suggestion in next patch.
I don't know why I didn't think of this naming at the time (*headwalls*).
In fact, I discovered this problem while contributing packfile-uris
related features (thinking about excluding tag objects), and finally
said to myself "So you are here" (although it didn't take so much effort),
So I decide to make this patch.
>>The call to it at the end is meant to sweep anything
>>leftover---we will not discover any tag while in the main loop of
>>the caller that iterates over commits (as they cannot contain any
>>tag in there).
Some doubts.
I think at the object relationship level: tag> commit> tree> blob
The tag is on top because of the annotated tag. So, why the tag is
in `revs->pending` to deal? I understand it should be the opposite?
A commit should pending to a tag, at least equal.
Maybe my understanding is wrong, if so, why this way?
Thank you.
next prev parent reply other threads:[~2021-08-12 7:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 9:07 [PATCH v1 0/1] traverse_trees_and_blobs: rename and tree-wide Teng Long
2021-08-11 9:07 ` [PATCH v1 1/1] list-objects.c: " Teng Long
2021-08-11 18:00 ` Junio C Hamano
2021-08-11 19:11 ` Jeff King
2021-08-12 8:05 ` Teng Long
2021-08-12 7:54 ` Teng Long [this message]
2021-08-12 8:47 ` [PATCH v2 0/1] list-objects.c: rename "traverse_trees_and_blobs" to "traverse_non_commits" Teng Long
2021-08-12 8:47 ` [PATCH v2 1/1] " Teng Long
2021-08-12 8:59 ` [PATCH v3 0/1] " Teng Long
2021-08-12 8:59 ` [PATCH v3 1/1] " Teng Long
2021-08-12 19:24 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210812075415.5114-1-dyroneteng@gmail.com \
--to=dyroneteng@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).