From: Teng Long <dyroneteng@gmail.com>
To: peff@peff.net
Cc: dyroneteng@gmail.com, git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH v1 1/1] list-objects.c: traverse_trees_and_blobs: rename and tree-wide
Date: Thu, 12 Aug 2021 16:05:42 +0800 [thread overview]
Message-ID: <20210812080542.5469-1-dyroneteng@gmail.com> (raw)
In-Reply-To: <YRQg+IJ3cxb3Vk+c@coredump.intra.peff.net>
>>FWIW, I was about reply and suggest the exact same name. :)
>>
>>As something internal to list-objects.c, I don't think it matters all
>>that much either way. The name "traverse_commit_list()" is IMHO more
>>likely to confuse. It is public within the project, and of course
>>traverses any type of object. So "traverse_objects()" or something may
>>be more accurate.
On the basis of understanding the relationship between git objects,
`traverse_commit_list` is understandable, for me.
>>OTOH I do not find it all that confusing, and it may not be worth the
>>disruption to the code base.
Agree.
It’s interesting to read your reply, because of learning a lot of
abbreviations.
Thank you.
next prev parent reply other threads:[~2021-08-12 8:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 9:07 [PATCH v1 0/1] traverse_trees_and_blobs: rename and tree-wide Teng Long
2021-08-11 9:07 ` [PATCH v1 1/1] list-objects.c: " Teng Long
2021-08-11 18:00 ` Junio C Hamano
2021-08-11 19:11 ` Jeff King
2021-08-12 8:05 ` Teng Long [this message]
2021-08-12 7:54 ` Teng Long
2021-08-12 8:47 ` [PATCH v2 0/1] list-objects.c: rename "traverse_trees_and_blobs" to "traverse_non_commits" Teng Long
2021-08-12 8:47 ` [PATCH v2 1/1] " Teng Long
2021-08-12 8:59 ` [PATCH v3 0/1] " Teng Long
2021-08-12 8:59 ` [PATCH v3 1/1] " Teng Long
2021-08-12 19:24 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210812080542.5469-1-dyroneteng@gmail.com \
--to=dyroneteng@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).