From: Miriam Rubio <mirucam@gmail.com>
To: git@vger.kernel.org
Cc: Miriam Rubio <mirucam@gmail.com>
Subject: [PATCH v6 1/6] t6030-bisect-porcelain: add tests to control bisect run exit cases
Date: Thu, 2 Sep 2021 11:04:16 +0200 [thread overview]
Message-ID: <20210902090421.93113-2-mirucam@gmail.com> (raw)
In-Reply-To: <20210902090421.93113-1-mirucam@gmail.com>
There is a gap on bisect run test coverage related with error exits.
Add two tests to control these error cases.
Signed-off-by: Miriam Rubio <mirucam@gmail.com>
---
t/t6030-bisect-porcelain.sh | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/t/t6030-bisect-porcelain.sh b/t/t6030-bisect-porcelain.sh
index a1baf4e451..e61b8143fd 100755
--- a/t/t6030-bisect-porcelain.sh
+++ b/t/t6030-bisect-porcelain.sh
@@ -962,4 +962,15 @@ test_expect_success 'bisect handles annotated tags' '
grep "$bad is the first bad commit" output
'
+test_expect_success 'bisect run fails with exit code equals or greater than 128' '
+ write_script test_script.sh <<-\EOF &&
+ exit 128 >/dev/null
+ EOF
+ test_must_fail git bisect run ./test_script.sh > my_bisect_log.txt &&
+ write_script test_script.sh <<-\EOF &&
+ exit 255 >/dev/null
+ EOF
+ test_must_fail git bisect run ./test_script.sh >> my_bisect_log.txt
+'
+
test_done
--
2.29.2
next prev parent reply other threads:[~2021-09-02 9:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 9:04 [PATCH v6 0/6] Finish converting git bisect to C part 4 Miriam Rubio
2021-09-02 9:04 ` Miriam Rubio [this message]
2021-09-02 21:44 ` [PATCH v6 1/6] t6030-bisect-porcelain: add tests to control bisect run exit cases Junio C Hamano
2021-09-02 9:04 ` [PATCH v6 2/6] t6030-bisect-porcelain: add test for bisect visualize Miriam Rubio
2021-09-02 22:05 ` Junio C Hamano
2021-09-02 9:04 ` [PATCH v6 3/6] run-command: make `exists_in_PATH()` non-static Miriam Rubio
2021-09-02 22:19 ` Junio C Hamano
2021-09-02 9:04 ` [PATCH v6 4/6] bisect--helper: reimplement `bisect_visualize()`shell function in C Miriam Rubio
2021-09-02 22:28 ` Junio C Hamano
2021-09-02 9:04 ` [PATCH v6 5/6] bisect--helper: reimplement `bisect_run` shell Miriam Rubio
2021-09-02 23:43 ` Junio C Hamano
2021-09-06 7:33 ` Johannes Schindelin
2021-09-06 8:34 ` Miriam R.
2021-09-07 18:32 ` Junio C Hamano
2021-09-09 7:51 ` Johannes Schindelin
2021-09-02 9:04 ` [PATCH v6 6/6] bisect--helper: retire `--bisect-next-check` subcommand Miriam Rubio
2021-09-02 23:43 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210902090421.93113-2-mirucam@gmail.com \
--to=mirucam@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).