From: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>
To: git@vger.kernel.org
Cc: bagasdotme@gmail.com, emilyshaffer@google.com,
"Carlo Marcelo Arenas Belón" <carenas@gmail.com>
Subject: [PATCH 1/2] bugreport: avoid duplicating options in usage()
Date: Fri, 3 Sep 2021 19:12:30 -0700 [thread overview]
Message-ID: <20210904021231.88534-2-carenas@gmail.com> (raw)
In-Reply-To: <20210904021231.88534-1-carenas@gmail.com>
238b439d69 (bugreport: add tool to generate debugging info, 2020-04-16)
includes the options with the commandline, which then means they will
be duplicated in the output of `git bugreport -h`.
remove them and while at it, make sure usage() is called if the wrong
number of parameters is provided (ex: `git bugreport help`)
Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
---
builtin/bugreport.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/builtin/bugreport.c b/builtin/bugreport.c
index 9915a5841d..17042381c3 100644
--- a/builtin/bugreport.c
+++ b/builtin/bugreport.c
@@ -5,7 +5,6 @@
#include "compat/compiler.h"
#include "run-command.h"
-
static void get_system_info(struct strbuf *sys_info)
{
struct utsname uname_info;
@@ -87,7 +86,7 @@ static void get_populated_hooks(struct strbuf *hook_info, int nongit)
}
static const char * const bugreport_usage[] = {
- N_("git bugreport [-o|--output-directory <file>] [-s|--suffix <format>]"),
+ N_("git bugreport"),
NULL
};
@@ -141,6 +140,8 @@ int cmd_bugreport(int argc, const char **argv, const char *prefix)
argc = parse_options(argc, argv, prefix, bugreport_options,
bugreport_usage, 0);
+ if (argc)
+ usage_with_options(bugreport_usage, bugreport_options);
/* Prepare the path to put the result */
prefixed_filename = prefix_filename(prefix,
--
2.33.0.481.g26d3bed244
next prev parent reply other threads:[~2021-09-04 2:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-03 11:59 [PATCH] Documentation: fix default directory of git bugreport -o Bagas Sanjaya
2021-09-04 2:12 ` bugreport papercuts Carlo Marcelo Arenas Belón
2021-09-04 2:12 ` Carlo Marcelo Arenas Belón [this message]
2021-09-07 21:39 ` [PATCH 1/2] bugreport: avoid duplicating options in usage() Junio C Hamano
2021-09-04 2:12 ` [PATCH 2/2] bugreport: slightly better memory management Carlo Marcelo Arenas Belón
2021-09-07 21:56 ` Junio C Hamano
2021-09-04 6:01 ` bugreport papercuts Bagas Sanjaya
2021-09-07 21:09 ` [PATCH] Documentation: fix default directory of git bugreport -o Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210904021231.88534-2-carenas@gmail.com \
--to=carenas@gmail.com \
--cc=bagasdotme@gmail.com \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).