From: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>
To: git@vger.kernel.org
Cc: sam@vilain.net, avarab@gmail.com,
"Carlo Marcelo Arenas Belón" <carenas@gmail.com>
Subject: [PATCH 0/3] cvsserver: correctly validate pserver passwords
Date: Wed, 15 Sep 2021 01:09:45 -0700 [thread overview]
Message-ID: <20210915080948.11891-1-carenas@gmail.com> (raw)
The first patch should be applied by any user of git-cvsserver, and
hashes for all pserver accounts updated; because the code originally
was using the username instead of the password to validate accounts,
and it might had even worked if the first 2 characters of the password
where the same (ex: cvsuser/cvspassword).
The second one allows for successfully running t9400 in OpenBSD and
will protect the code further from the possible use of an undef
variable, and shows that support for better password hashes than DES
is possible.
Carlo Marcelo Arenas Belón (3):
git-cvsserver: use crypt correctly to compare password hashes
git-cvsserver: protect against NULL in crypt(3)
Documentation: cleanup git-cvsserver
Documentation/git-cvsserver.txt | 27 +++++++++++++--------------
git-cvsserver.perl | 7 ++++---
t/t9400-git-cvsserver-server.sh | 9 ++++++++-
3 files changed, 25 insertions(+), 18 deletions(-)
--
2.33.0.481.g26d3bed244
next reply other threads:[~2021-09-15 8:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 8:09 Carlo Marcelo Arenas Belón [this message]
2021-09-15 8:09 ` [PATCH 1/3] git-cvsserver: use crypt correctly to compare password hashes Carlo Marcelo Arenas Belón
2021-09-15 8:09 ` [PATCH 2/3] git-cvsserver: protect against NULL in crypt(3) Carlo Marcelo Arenas Belón
2021-09-16 22:11 ` Junio C Hamano
2021-09-16 22:44 ` Carlo Arenas
2021-09-17 3:43 ` Junio C Hamano
2021-09-15 8:09 ` [PATCH 3/3] Documentation: cleanup git-cvsserver Carlo Marcelo Arenas Belón
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210915080948.11891-1-carenas@gmail.com \
--to=carenas@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=sam@vilain.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).