git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: git@vger.kernel.org
Cc: wolf@oriole.systems, Bagas Sanjaya <bagasdotme@gmail.com>
Subject: [PATCH] rev-parse: fix mismatch quoting of separator in the message
Date: Wed, 22 Sep 2021 18:17:45 +0700	[thread overview]
Message-ID: <20210922111744.675326-1-bagasdotme@gmail.com> (raw)

There is a quoting mismatch quoting `--` separator in "no usage string
given...." message (`' instead of ``). Fix it.

Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
---
 builtin/rev-parse.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/builtin/rev-parse.c b/builtin/rev-parse.c
index 22c4e1a4ff..a35dbad6c4 100644
--- a/builtin/rev-parse.c
+++ b/builtin/rev-parse.c
@@ -439,7 +439,7 @@ static int cmd_parseopt(int argc, const char **argv, const char *prefix)
 		ALLOC_GROW(usage, unb + 1, usz);
 		if (!strcmp("--", sb.buf)) {
 			if (unb < 1)
-				die(_("no usage string given before the `--' separator"));
+				die(_("no usage string given before the `--` separator"));
 			usage[unb] = NULL;
 			break;
 		}

base-commit: 99c99ed8259bf070cd8ae7b51a94904b7cf5c161
-- 
2.25.1


             reply	other threads:[~2021-09-22 11:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-22 11:17 Bagas Sanjaya [this message]
2021-09-22 17:40 ` [PATCH] rev-parse: fix mismatch quoting of separator in the message Taylor Blau
2021-09-22 19:28   ` Junio C Hamano
2021-09-22 19:42     ` Taylor Blau
2021-09-22 19:59       ` Ævar Arnfjörð Bjarmason
2021-09-22 20:08         ` Taylor Blau
2021-09-22 20:58           ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210922111744.675326-1-bagasdotme@gmail.com \
    --to=bagasdotme@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=wolf@oriole.systems \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).