From: Eric Wong <e@80x24.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>,
git@vger.kernel.org, Eric Sunshine <sunshine@sunshineco.com>,
"brian m. carlson" <sandals@crustytoothpaste.net>
Subject: Re: [PATCH] tests: disable fsync everywhere
Date: Fri, 29 Oct 2021 07:48:57 +0000 [thread overview]
Message-ID: <20211029074857.GA9214@dcvr> (raw)
In-Reply-To: <xmqqy26cl1zd.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> wrote:
> Eric Wong <e@80x24.org> writes:
>
> > v2 changes:
> > * s/GIT_FSYNC/GIT_TEST_FSYNC/
> > * disable fsync by default for tests, reduces setup for newcomers
> > * fix style nit noted by Eric Sunshine
>
> https://github.com/git/git/runs/4043532265?check_suite_focus=true#step:5:70
Fwiw, I couldn't view that (not sure if it's from lack of JS
or lack of GH account). Either way it's accessibility problem.
> Seems to be dying in "git svn" tests somehow.
Easy repro+fix, though. I only tested my final patch with NO_SVN_TESTS :x
Can you squash this in or do you want a reroll?
diff --git a/perl/Git/SVN.pm b/perl/Git/SVN.pm
index df5a87a151..6ce2e283c8 100644
--- a/perl/Git/SVN.pm
+++ b/perl/Git/SVN.pm
@@ -2274,7 +2274,7 @@ sub use_fsync {
if (!defined($_use_fsync)) {
my $x = $ENV{GIT_TEST_FSYNC};
if (defined $x) {
- my $v = command_oneline('git', '-c', "test.fsync=$x",
+ my $v = command_oneline('-c', "test.fsync=$x",
qw(config --type=bool test.fsync));
$_use_fsync = defined($v) ? ($v eq "true\n") : 1;
}
next prev parent reply other threads:[~2021-10-29 7:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 0:21 [PATCH] allow disabling fsync everywhere Eric Wong
2021-10-28 1:21 ` Eric Sunshine
2021-10-28 14:36 ` Jeff King
2021-10-28 18:28 ` Eric Wong
2021-10-28 19:29 ` Junio C Hamano
2021-10-29 0:15 ` [PATCH] tests: disable " Eric Wong
2021-10-29 5:18 ` Junio C Hamano
2021-10-29 7:56 ` Eric Wong
2021-10-29 18:12 ` Junio C Hamano
2021-10-29 7:33 ` Junio C Hamano
2021-10-29 7:48 ` Eric Wong [this message]
2021-10-29 17:22 ` Junio C Hamano
2021-10-29 20:34 ` Jeff King
2021-10-29 20:42 ` Junio C Hamano
2021-10-28 21:40 ` [PATCH] allow disabling " brian m. carlson
2021-10-29 11:20 ` Ævar Arnfjörð Bjarmason
2021-10-30 10:39 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211029074857.GA9214@dcvr \
--to=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=sandals@crustytoothpaste.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).