From: Eric Wong <e@80x24.org>
To: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: users@linux.kernel.org, tools@linux.kernel.org, git@vger.kernel.org
Subject: Re: b4: unicode control characters -- warn or remove?
Date: Mon, 1 Nov 2021 19:09:05 +0000 [thread overview]
Message-ID: <20211101190905.M853114@dcvr> (raw)
In-Reply-To: <20211101175020.5r4cwmy4qppi7dis@meerkat.local>
Konstantin Ryabitsev <konstantin@linuxfoundation.org> wrote:
> Hi, all:
>
> Per exhibit a, what should we do in the situation where we discover unicode
> control characters in an email?
>
> 1. Warn and strip these chars out, because they are extremely unlikely to be
> doing anything legitimate in the context of a patch (unless someone is
> sending patches for docs actually written in RTL languages)
> 2. Warn and error out, refusing to produce an mbox
> 3. Just warn and produce an mbox anyway
>
> I'd normally do #3, but with many people piping things to git-am, I'm not sure
> if it's the safest choice.
>
> Exibit a: https://lwn.net/Articles/874546/
+Cc: git@vger
IMHO, defense for this belongs in git-am (which already checks
things like whitespace).
next parent reply other threads:[~2021-11-01 19:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211101175020.5r4cwmy4qppi7dis@meerkat.local>
2021-11-01 19:09 ` Eric Wong [this message]
2021-11-01 19:17 ` b4: unicode control characters -- warn or remove? Konstantin Ryabitsev
2021-11-01 20:02 ` Ævar Arnfjörð Bjarmason
2021-11-01 20:22 ` Konstantin Ryabitsev
2021-11-01 20:49 ` Pavel Machek
2021-11-01 21:02 ` Konstantin Ryabitsev
2021-11-02 14:09 ` Konstantin Ryabitsev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211101190905.M853114@dcvr \
--to=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=konstantin@linuxfoundation.org \
--cc=tools@linux.kernel.org \
--cc=users@linux.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).