From: Bagas Sanjaya <bagasdotme@gmail.com>
To: git@vger.kernel.org
Cc: "Jonathan Tan" <jonathantanmy@google.com>,
"Christopher Diaz Riveros" <christopher.diaz.riv@gmail.com>,
"Jean-Noël Avila" <jn.avila@free.fr>,
"Daniel Santos" <hello@brighterdan.com>,
"Bagas Sanjaya" <bagasdotme@gmail.com>
Subject: [PATCH] fetch-pack: add TRANSLATORS notice for packfile ready messages
Date: Sun, 14 Nov 2021 14:31:43 +0700 [thread overview]
Message-ID: <20211114073143.84004-1-bagasdotme@gmail.com> (raw)
Two messages mention "... to be sent after 'ready'". The 'ready' string,
however, is actually in part of packet stream, which shouldn't be
translated. Because of lack of any notices, l10n teams treat it as
ordinary string, which results to inconsistency across teams. That is,
in `po/es.po` the string is translated:
```
msgid "expected packfile to be sent after 'ready'"
msgstr "se esperaba que el packfile fuera enviado luego del 'listo'"
msgid "expected no other sections to be sent after no 'ready'"
msgstr "se esperaba que ninguna otra sección fuera enviada luego del 'listo'"
```
whereas in `po/fr.po` and `po/de.po`, the string isn't translated:
```
msgid "expected packfile to be sent after 'ready'"
msgstr "fichier paquet attendu à envoyer après 'ready'"
msgid "expected no other sections to be sent after no 'ready'"
msgstr "aucune autre section attendue à envoyer après absence de 'ready'"
```
```
msgid "expected packfile to be sent after 'ready'"
msgstr "Erwartete Versand einer Packdatei nach 'ready'."
msgid "expected no other sections to be sent after no 'ready'"
msgstr "Erwartete keinen Versand einer anderen Sektion ohne 'ready'."
```
To avoid confusions, add TRANSLATORS notice.
Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
---
fetch-pack.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/fetch-pack.c b/fetch-pack.c
index a9604f35a3..0cda8fc518 100644
--- a/fetch-pack.c
+++ b/fetch-pack.c
@@ -1410,8 +1410,12 @@ static int process_ack(struct fetch_negotiator *negotiator,
* otherwise.
*/
if (*received_ready && reader->status != PACKET_READ_DELIM)
+ /* TRANSLATORS: 'ready' string is in part of packet stream.
+ Leave it as is. */
die(_("expected packfile to be sent after 'ready'"));
if (!*received_ready && reader->status != PACKET_READ_FLUSH)
+ /* TRANSLATORS: 'ready' string is in part of packet stream.
+ Leave it as is. */
die(_("expected no other sections to be sent after no 'ready'"));
return 0;
base-commit: 6c220937e2b26d85920bf2d38ff2464a0d57fd6b
--
An old man doll... just what I always wanted! - Clara
next reply other threads:[~2021-11-14 7:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-14 7:31 Bagas Sanjaya [this message]
2021-11-14 9:50 ` [PATCH] fetch-pack: add TRANSLATORS notice for packfile ready messages Ævar Arnfjörð Bjarmason
2021-11-15 5:41 ` Bagas Sanjaya
2021-11-15 15:21 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211114073143.84004-1-bagasdotme@gmail.com \
--to=bagasdotme@gmail.com \
--cc=christopher.diaz.riv@gmail.com \
--cc=git@vger.kernel.org \
--cc=hello@brighterdan.com \
--cc=jn.avila@free.fr \
--cc=jonathantanmy@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).