From: Fabian Stelzer <fs@gigacodes.de>
To: git@vger.kernel.org
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Adam Dinwoodie" <adam@dinwoodie.org>,
"Jeff King" <peff@peff.net>, "Junio C Hamano" <gitster@pobox.com>,
"Fabian Stelzer" <fs@gigacodes.de>
Subject: [PATCH v2 0/2] test-lib: improve missing prereq handling
Date: Wed, 17 Nov 2021 10:04:08 +0100 [thread overview]
Message-ID: <20211117090410.8013-1-fs@gigacodes.de> (raw)
The ssh signing feature was breaking tests when the broken openssh-8.7
was used. We have now fixed that by checking for this exact case in the
GPGSSH prereq and I will improve that check further in a future patch.
However we are now in a situation where a broken openssh in the future
will result in successfull tests but not a working git build afterwards
(either not compiling in the expected feature or like in the ssh case
runtime failures) resulting in a false sense of security in the tests.
This patches try to improve this situation by showing which prereqs
failed in the test summary and by adding an environment variable to
enforce certain prereqs to succeed or abort the test otherwise.
See also:
https://public-inbox.org/git/xmqqv916wh7t.fsf@gitster.g/
changes since v1:
- use \012 instead of \n for possible portability reasons
- fix typo in commit msg
Fabian Stelzer (2):
test-lib: show missing prereq summary
test-lib: introduce required prereq for test runs
t/README | 6 ++++++
t/aggregate-results.sh | 17 +++++++++++++++++
t/test-lib-functions.sh | 11 +++++++++++
t/test-lib.sh | 11 +++++++++++
4 files changed, 45 insertions(+)
Range-diff against v1:
1: 69e77cd854 ! 1: 775c0e5ef0 test-lib: show missing prereq summary
@@ t/aggregate-results.sh: do
+then
+ unique_missing_prereq=$(
+ echo $missing_prereq |
-+ tr -s "," "\n" |
++ tr -s "," "\012" |
+ grep -v '^$' |
+ sort -u |
+ paste -s -d ',')
2: 12bd18c5ce ! 2: eb1bbb8d01 test-lib: introduce required prereq for test runs
@@ Commit message
test-lib: introduce required prereq for test runs
In certain environments or for specific test scenarios we might expect a
- specific prerequisite check to be succeed. Therefore we would like to
+ specific prerequisite check to succeed. Therefore we would like to
trigger an error when running our tests if this is not the case.
To remedy this we add the environment variable GIT_TEST_REQUIRE_PREREQ
--
2.31.1
next reply other threads:[~2021-11-17 9:04 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 9:04 Fabian Stelzer [this message]
2021-11-17 9:04 ` [PATCH v2 1/2] test-lib: show missing prereq summary Fabian Stelzer
2021-11-17 9:04 ` [PATCH v2 2/2] test-lib: introduce required prereq for test runs Fabian Stelzer
2021-11-18 23:42 ` Junio C Hamano
2021-11-19 9:07 ` Fabian Stelzer
2021-11-19 11:13 ` Ævar Arnfjörð Bjarmason
2021-11-19 13:48 ` Fabian Stelzer
2021-11-19 14:09 ` Fabian Stelzer
2021-11-19 14:26 ` Ævar Arnfjörð Bjarmason
2021-11-19 15:40 ` Fabian Stelzer
2021-11-19 16:37 ` Ævar Arnfjörð Bjarmason
2021-11-20 15:03 ` [PATCH v3 0/3] test-lib: improve missing prereq handling Fabian Stelzer
2021-11-20 15:03 ` [PATCH v3 1/3] test-lib: show missing prereq summary Fabian Stelzer
2021-11-20 15:04 ` [PATCH v3 2/3] test-lib: introduce required prereq for test runs Fabian Stelzer
2021-11-20 15:04 ` [PATCH v3 3/3] test-lib: make BAIL_OUT() work in tests and prereq Fabian Stelzer
2021-11-22 11:52 ` Ævar Arnfjörð Bjarmason
2021-11-22 17:05 ` Junio C Hamano
2021-11-26 9:55 ` Fabian Stelzer
2021-11-26 21:02 ` Junio C Hamano
2021-11-27 12:47 ` Fabian Stelzer
2021-11-28 23:38 ` Junio C Hamano
2021-11-30 14:38 ` Fabian Stelzer
2021-11-30 14:59 ` Ævar Arnfjörð Bjarmason
2021-12-01 8:53 ` [PATCH v4 0/3] test-lib: improve missing prereq handling Fabian Stelzer
2021-12-01 8:53 ` [PATCH v4 1/3] test-lib: show missing prereq summary Fabian Stelzer
2021-12-01 8:53 ` [PATCH v4 2/3] test-lib: introduce required prereq for test runs Fabian Stelzer
2021-12-01 8:53 ` [PATCH v4 3/3] test-lib: make BAIL_OUT() work in tests and prereq Fabian Stelzer
2021-12-01 23:13 ` Junio C Hamano
2021-12-01 21:05 ` [PATCH v4 0/3] test-lib: improve missing prereq handling Adam Dinwoodie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211117090410.8013-1-fs@gigacodes.de \
--to=fs@gigacodes.de \
--cc=adam@dinwoodie.org \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).