From: Fabian Stelzer <fs@gigacodes.de>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>, Taylor Blau <me@ttaylorr.com>,
Eric Sunshine <sunshine@sunshineco.com>,
Fabian Stelzer <fs@gigacodes.de>
Subject: [PATCH v3 0/2] ssh signing: support non ssh-* keytypes
Date: Fri, 19 Nov 2021 16:07:05 +0100 [thread overview]
Message-ID: <20211119150707.3924636-1-fs@gigacodes.de> (raw)
In-Reply-To: <20211117162727.650857-1-fs@gigacodes.de>
support generic ssh keytypes using a `key::` prefix instead of relying
on ssh- prefixes.
changes since v2:
- no longer hide that we still support `ssh-` prefixes for literal
keys.
Fabian Stelzer (2):
ssh signing: support non ssh-* keytypes
ssh signing: make sign/amend test more resilient
Documentation/config/user.txt | 17 ++++++++++-------
gpg-interface.c | 36 ++++++++++++++++++++++++++++-------
t/lib-gpg.sh | 3 +++
t/t7510-signed-commit.sh | 2 +-
t/t7528-signed-commit-ssh.sh | 26 +++++++++++++++++++++++--
5 files changed, 67 insertions(+), 17 deletions(-)
Range-diff against v2:
1: ea032f98f0 ! 1: 865a32d37c ssh signing: support non ssh-* keytypes
@@ Documentation/config/user.txt: user.signingKey::
+ directly (e.g.: "key::ssh-rsa XXXXXX identifier"). The private key
+ needs to be available via ssh-agent. If not set git will call
+ gpg.ssh.defaultKeyCommand (e.g.: "ssh-add -L") and try to use the
-+ first key available.
++ first key available. For backward compatibility, a raw key which
++ begins with "ssh-", such as "ssh-rsa XXXXXX identifier", is treated
++ as "key::ssh-rsa XXXXXX identifier", but this form is deprecated;
++ use the `key::` form instead.
## gpg-interface.c ##
@@ gpg-interface.c: int git_gpg_config(const char *var, const char *value, void *cb)
2: 5054ff0e76 = 2: 868cb7f524 ssh signing: make sign/amend test more resilient
base-commit: cd3e606211bb1cf8bc57f7d76bab98cc17a150bc
--
2.31.1
next prev parent reply other threads:[~2021-11-19 15:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 16:27 [PATCH] ssh signing: support non ssh-* keytypes Fabian Stelzer
2021-11-17 17:51 ` Taylor Blau
2021-11-18 3:09 ` Junio C Hamano
2021-11-18 6:39 ` Junio C Hamano
2021-11-18 15:16 ` Fabian Stelzer
2021-11-18 17:14 ` [PATCH v2 1/2] " Fabian Stelzer
2021-11-18 17:14 ` [PATCH v2 2/2] ssh signing: make sign/amend test more resilient Fabian Stelzer
2021-11-18 22:14 ` [PATCH v2 1/2] ssh signing: support non ssh-* keytypes Eric Sunshine
2021-11-19 9:05 ` Fabian Stelzer
2021-11-19 15:07 ` Fabian Stelzer [this message]
2021-11-19 15:07 ` [PATCH v3 " Fabian Stelzer
2021-11-19 15:07 ` [PATCH v3 2/2] ssh signing: make sign/amend test more resilient Fabian Stelzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211119150707.3924636-1-fs@gigacodes.de \
--to=fs@gigacodes.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@ttaylorr.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).