From: Plato Kiorpelidis <kioplato@gmail.com>
To: git@vger.kernel.org
Cc: matheus.bernardino@usp.br, mhagger@alum.mit.edu,
Plato Kiorpelidis <kioplato@gmail.com>
Subject: [RFC PATCH 5/6] t0066: remove redundant tests
Date: Sun, 10 Apr 2022 14:18:51 +0300 [thread overview]
Message-ID: <20220410111852.2097418-6-kioplato@gmail.com> (raw)
In-Reply-To: <20220410111852.2097418-1-kioplato@gmail.com>
Remove dir-iterator redundant tests since the new tests introduced in
045738486f (t0066: better test coverage for dir-iterator, 2022-04-07)
supersede them.
Signed-off-by: Plato Kiorpelidis <kioplato@gmail.com>
---
t/t0066-dir-iterator.sh | 40 ----------------------------------------
1 file changed, 40 deletions(-)
diff --git a/t/t0066-dir-iterator.sh b/t/t0066-dir-iterator.sh
index 24a4f1afef..974bb13092 100755
--- a/t/t0066-dir-iterator.sh
+++ b/t/t0066-dir-iterator.sh
@@ -894,46 +894,6 @@ test_expect_success 'dir_iterator_begin() should fail upon non directory paths'
test_cmp expected-non-dir-out actual-out
'
-test_expect_success POSIXPERM,SANITY \
-'dir_iterator_advance() should not fail on errors by default' '
-
- mkdir -p dir13/a &&
- >dir13/a/b &&
- chmod 0 dir13/a &&
-
-
- cat >expected-no-permissions-out <<-EOF &&
- [d] (a) [a] ./dir13/a
- EOF
-
- test-tool dir-iterator --dirs-before ./dir13 >actual-out &&
- test_cmp expected-no-permissions-out actual-out &&
-
- chmod 755 dir13/a &&
- rm -rf dir13
-'
-
-test_expect_success POSIXPERM,SANITY \
-'dir_iterator_advance() should fail on errors, w/ pedantic flag' '
-
- mkdir -p dir13/a &&
- >dir13/a/b &&
- chmod 0 dir13/a &&
-
-
- cat >expected-no-permissions-pedantic-out <<-EOF &&
- [d] (a) [a] ./dir13/a
- dir_iterator_advance failure
- EOF
-
- test_must_fail test-tool dir-iterator --dirs-before \
- --pedantic ./dir13 >actual-out &&
- test_cmp expected-no-permissions-pedantic-out actual-out &&
-
- chmod 755 dir13/a &&
- rm -rf dir13
-'
-
test_expect_success SYMLINKS 'setup -- dir w/ symlinks w/o cycle' '
mkdir -p dir14/a &&
mkdir -p dir14/b/c &&
--
2.35.1
next prev parent reply other threads:[~2022-04-10 11:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-10 11:18 [RFC PATCH 0/6][GSoC] iterate dirs before or after their contents Plato Kiorpelidis
2022-04-10 11:18 ` [RFC PATCH 1/6] t0066: improve readablity of dir-iterator tests Plato Kiorpelidis
2022-04-11 13:16 ` Phillip Wood
2022-04-24 19:25 ` Plato Kiorpelidis
2022-04-10 11:18 ` [RFC PATCH 2/6] t0066: better test coverage for dir-iterator Plato Kiorpelidis
2022-04-10 11:18 ` [RFC PATCH 3/6] dir-iterator: refactor dir_iterator_advance() Plato Kiorpelidis
2022-04-11 11:11 ` Ævar Arnfjörð Bjarmason
2022-04-11 13:40 ` Phillip Wood
2022-04-27 15:45 ` Plato Kiorpelidis
2022-04-11 13:26 ` Phillip Wood
2022-04-27 14:32 ` Plato Kiorpelidis
2022-04-10 11:18 ` [RFC PATCH 4/6] dir-iterator: iterate dirs before or after their contents Plato Kiorpelidis
2022-04-11 13:31 ` Phillip Wood
2022-04-27 14:57 ` Plato Kiorpelidis
2022-04-10 11:18 ` Plato Kiorpelidis [this message]
2022-04-11 11:10 ` [RFC PATCH 5/6] t0066: remove redundant tests Ævar Arnfjörð Bjarmason
2022-04-27 16:00 ` Plato Kiorpelidis
2022-04-10 11:18 ` [RFC PATCH 6/6] test-dir-iterator: handle EACCES errno by dir-iterator Plato Kiorpelidis
2022-04-11 11:04 ` Ævar Arnfjörð Bjarmason
2022-04-27 17:30 ` Plato Kiorpelidis
2022-04-11 13:37 ` [RFC PATCH 0/6][GSoC] iterate dirs before or after their contents Phillip Wood
2022-04-19 13:06 ` Plato Kiorpelidis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220410111852.2097418-6-kioplato@gmail.com \
--to=kioplato@gmail.com \
--cc=git@vger.kernel.org \
--cc=matheus.bernardino@usp.br \
--cc=mhagger@alum.mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).