Git development
 help / color / mirror / Atom feed
From: Alyssa Ross <hi@alyssa.is>
To: Junio C Hamano <gitster@pobox.com>, Johannes Sixt <j6t@kdbg.org>
Cc: git@vger.kernel.org, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: Failures in t9001-send-email
Date: Fri, 22 Apr 2022 08:00:52 +0000	[thread overview]
Message-ID: <20220422080052.diovj33bfnra62uv@eve> (raw)
In-Reply-To: <xmqq7d7hd31g.fsf@gitster.g>

[-- Attachment #1: Type: text/plain, Size: 1660 bytes --]

On Thu, Apr 21, 2022 at 11:51:07PM -0700, Junio C Hamano wrote:
> Johannes Sixt <j6t@kdbg.org> writes:
>
> >> I had a look at the tests to try to guess what was wrong, but I didn't
> >> come up with anything.  Any ideas?
> >
> > You run ./t9001-send-email.sh (without `prove`). Add -v to see some
> > verbiage from the tests, throw in -i to have it stop at the first
> > failure (so you don't have to scroll back to find it), and add -x for
> > additional traces of commands that the shell executes (to see the exact
> > command that failed).
> >
> > IFAIC, I always go all in, i.e., either all or none of -v -i -x.
>
> Good suggestion.
>
> I rarely (if ever) use "-x" myself but another useful thing to know,
> while learning how the existing test works (i.e. studying a working
> test, not debugging a broken test) is to use "-d", possibly together
> with "-v", which refrains from removing the trash directory.  Then
> you can go in and examine the state of the test repository the tests
> left.

Thank you both for these tips.

I was able to determine the issue by running the test with -vixd,
noticing which command failed, and then trying to set up my shell
environment manually to match the test's (PATH, PERLLIB,
committer/author info, etc.), and ran the same command with the leftover
trash directory.  This produced error output that didn't show up when I
was running the test (not sure why) that gave me a line number in
git-send-email.perl.  I noticed that it was trying to load
Term::ReadLine near that line, and I didn't have that installed in my
development environment.

Now that I have that installed, all send-email tests pass.
Thanks again!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2022-04-22  8:00 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-21 19:48 Should sendemail.confirm default to always? Alyssa Ross
2022-04-21 19:58 ` Ævar Arnfjörð Bjarmason
2022-04-21 21:47   ` Junio C Hamano
2022-04-21 22:38   ` Failures in t9001-send-email Alyssa Ross
2022-04-21 23:19     ` rsbecker
2022-04-22  7:56       ` Alyssa Ross
2022-04-22 10:41         ` rsbecker
2022-04-22  5:40     ` Johannes Sixt
2022-04-22  6:51       ` Junio C Hamano
2022-04-22  8:00         ` Alyssa Ross [this message]
2022-04-22  8:36   ` [PATCH] send-email: always confirm by default Alyssa Ross
2022-04-22 11:16     ` Ævar Arnfjörð Bjarmason
2022-04-22 17:09     ` Junio C Hamano
2022-04-21 20:04 ` Should sendemail.confirm default to always? Junio C Hamano
2022-04-21 20:37   ` Alyssa Ross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220422080052.diovj33bfnra62uv@eve \
    --to=hi@alyssa.is \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=j6t@kdbg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox