From: "lilinchao@oschina.cn" <lilinchao@oschina.cn>
To: git <git@vger.kernel.org>
Cc: "Junio C Hamano" <gitster@pobox.com>
Subject: Re: protocol: add Accept-Language header if possible
Date: Sat, 4 Jun 2022 02:33:30 +0800 [thread overview]
Message-ID: <202206040227197341312@oschina.cn> (raw)
In-Reply-To: 2022060211034177301214@oschina.cn
>Git server end's ability to accept Accept-Language header was introduced in f18604bbf2(http: add Accept-Language header if possible)
>but it seems that only refs discovering stage has this ability:
>"
>╰─$ GIT_CURL_VERBOSE=1 git ls-remote
>...
>10:42:36.939108 http.c:623 => Send header: GET /opensource/test.git/info/refs?service=git-upload-pack HTTP/1.1
>10:42:36.939112 http.c:623 => Send header: Host: gitee.com
>10:42:36.939114 http.c:623 => Send header: User-Agent: git/2.35.1.102.g2b9c120970
>10:42:36.939116 http.c:623 => Send header: Accept: */*
>10:42:36.939117 http.c:623 => Send header: Accept-Encoding: deflate, gzip
>10:42:36.939118 http.c:623 => Send header: Accept-Language: en-US, *;q=0.9
>10:42:36.939120 http.c:623 => Send header: Pragma: no-cache
>10:42:36.939121 http.c:623 => Send header: Git-Protocol: version=2
>10:42:36.939123 http.c:623 => Send header:
>...
>10:42:36.999012 http.c:611 => Send header, 0000000302 bytes (0x0000012e)
>10:42:36.999034 http.c:623 => Send header: GET /opensource/test.git/info/refs?service=git-upload-pack HTTP/1.1
>10:42:36.999039 http.c:623 => Send header: Host: gitee.com
>10:42:36.999041 http.c:623 => Send header: Authorization: Basic <redacted>
>10:42:36.999042 http.c:623 => Send header: User-Agent: git/2.35.1.102.g2b9c120970
>10:42:36.999044 http.c:623 => Send header: Accept: */*
>10:42:36.999063 http.c:623 => Send header: Accept-Encoding: deflate, gzip
>10:42:36.999081 http.c:623 => Send header: Accept-Language: en-US, *;q=0.9
>10:42:36.999101 http.c:623 => Send header: Pragma: no-cache
>10:42:36.999105 http.c:623 => Send header: Git-Protocol: version=2
>10:42:36.999106 http.c:623 => Send header:
>...
>10:42:37.098325 http.c:611 => Send header, 0000000341 bytes (0x00000155)
>10:42:37.098368 http.c:623 => Send header: POST /opensource/test.git/git-upload-pack HTTP/1.1
>10:42:37.098377 http.c:623 => Send header: Host: gitee.com
>10:42:37.098381 http.c:623 => Send header: Authorization: Basic <redacted>
>10:42:37.098384 http.c:623 => Send header: User-Agent: git/2.35.1.102.g2b9c120970
>10:42:37.098387 http.c:623 => Send header: Accept-Encoding: deflate, gzip
>10:42:37.098417 http.c:623 => Send header: Content-Type: application/x-git-upload-pack-request
>10:42:37.098421 http.c:623 => Send header: Accept: application/x-git-upload-pack-result
>10:42:37.098425 http.c:623 => Send header: Git-Protocol: version=2
>10:42:37.098428 http.c:623 => Send header: Content-Length: 118
>10:42:37.098431 http.c:623 => Send header:
>...
>"
>Why git-upload-pack/git-receive-pack stage doesn't enable this ability?
>
Can anyone tell me if this design is intentional.
next prev parent reply other threads:[~2022-06-03 18:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-02 3:18 protocol: add Accept-Language header if possible lilinchao
2022-06-03 18:33 ` lilinchao [this message]
2022-06-03 19:09 ` Junio C Hamano
2022-06-04 5:46 ` lilinchao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202206040227197341312@oschina.cn \
--to=lilinchao@oschina.cn \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).