git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "lilinchao@oschina.cn" <lilinchao@oschina.cn>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Li Linchao via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git <git@vger.kernel.org>
Subject: Re: Re: [PATCH] remote-curl: send Accept-Language header to server
Date: Fri, 10 Jun 2022 10:38:38 +0800	[thread overview]
Message-ID: <2022061010332322021051@oschina.cn> (raw)
In-Reply-To: 220609.86leu6thon.gmgdl@evledraar.gmail.com

Sorry, I mistakenly sent the reply email to you yesterday, I should click "Reply all" button :(

>
>On Wed, Jun 08 2022, Li Linchao via GitGitGadget wrote:
>
>> From: Cactusinhand <lilinchao@oschina.cn>
>>
>> Git server end's ability to accept Accept-Language header was introduced
>> in f18604bbf2(http: add Accept-Language header if possible), but this is
>> only used by very early phase of the transfer, that's HTTP GET request to
>> discover references. For other phases, like POST request in the smart HTTP
>> the server side don't know what language client speak.
>>
>> This patch teaches git client to learn end-user's preferred language and
>> throw accept-language header to server side. Once server get this header
>> it have ability to talk to end-user with language they understand, this
>> would be very helpful for many non-English speakers.
>
>I may be missing something, but this is just the "Accept-Language" part
>of this change, i.e. there is no "round-tripping" here of actually doing
>the work on the server of doing setlocale(), no?
Yes,  here Git just holds this header message, and the actual work depends
on the git service providers, like Github, Gitlab, or Gitee. 
>
>I think the end-goal of having the "remote: " messages translated, if
>possible, is very worthwhile, but I'd always imagined we'd do that with
>a protocol extension, because even if we do this with HTTP headers we
>won't get the same over ssh/git transports.
As for ssh transport, can we use ssh environment to reach our goal?
>
>But then again we don't have protocol v2 push yet :(
>
>So perfect certainly shouldn't be the enemy of the good here, I just
>wonder what the end-goal is and if there's a plan to get there.

Thanks.

  parent reply	other threads:[~2022-06-10  2:38 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-08  8:53 [PATCH] remote-curl: send Accept-Language header to server Li Linchao via GitGitGadget
2022-06-08 23:32 ` Junio C Hamano
2022-06-09  6:35 ` [PATCH v2] " Li Linchao via GitGitGadget
2022-06-09 23:55   ` Junio C Hamano
2022-06-10  3:49     ` lilinchao
2022-06-10  4:22       ` lilinchao
2022-06-12 17:20   ` [PATCH v3] " Li Linchao via GitGitGadget
2022-06-13 18:15     ` Junio C Hamano
2022-06-13 21:32     ` Junio C Hamano
2022-06-13 22:08       ` Junio C Hamano
2022-06-13 22:15         ` Junio C Hamano
2022-07-11  5:58     ` [PATCH v4] " Li Linchao via GitGitGadget
2022-06-09  7:30 ` [PATCH] " Ævar Arnfjörð Bjarmason
2022-06-09 17:34   ` Junio C Hamano
2022-06-10  2:38   ` lilinchao [this message]
2022-07-03  0:57     ` Junio C Hamano
2022-07-05 10:06       ` lilinchao
2022-07-05 10:15         ` Ævar Arnfjörð Bjarmason
2022-07-05 18:06           ` Junio C Hamano
2022-07-05 17:53         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2022061010332322021051@oschina.cn \
    --to=lilinchao@oschina.cn \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).