From: Calvin Wan <calvinwan@google.com>
To: git@vger.kernel.org
Cc: Calvin Wan <calvinwan@google.com>,
emilyshaffer@google.com, avarab@gmail.com,
phillip.wood123@gmail.com
Subject: [PATCH v3 0/6] submodule: parallelize diff
Date: Thu, 20 Oct 2022 23:25:26 +0000 [thread overview]
Message-ID: <20221020232532.1128326-1-calvinwan@google.com> (raw)
In-Reply-To: <https://lore.kernel.org/git/20221011232604.839941-1-calvinwan@google.com/>
Original cover letter for context:
https://lore.kernel.org/git/20221011232604.839941-1-calvinwan@google.com/
Changes since v2
Rebased on top of Avar's v3 run-command refactor[1]
pipe_output_fn has been decoupled from 'err' and now uses a new
variable in run_processes_parallel_opts, 'out'. This simplifies much
of the logic and testing difficulty of the previous patch, since 'out'
only holds output from child processes and nothing else.
Added a new patch to add hide_output to run_processes_parallel_opts. I
previously was reseting 'err' as to not print output from child
processes, but that was an unnecessary complication. A simple option to
not print output is much cleaner.
Added a setup patch before "submodule: move status parsing into function"
Fixed many stylistic changes and rewrote some documentation recommended
by Avar -- thank you for your reviews!
[1] https://lore.kernel.org/git/cover-v3-00.15-00000000000-20221012T205712Z-avarab@gmail.com/
Calvin Wan (6):
run-command: add pipe_output_fn to run_processes_parallel_opts
run-command: add hide_output to run_processes_parallel_opts
submodule: strbuf variable rename
submodule: move status parsing into function
diff-lib: refactor match_stat_with_submodule
diff-lib: parallelize run_diff_files for submodules
Documentation/config/submodule.txt | 12 ++
diff-lib.c | 102 +++++++++++--
run-command.c | 29 +++-
run-command.h | 30 ++++
submodule.c | 232 +++++++++++++++++++++++++----
submodule.h | 9 ++
t/helper/test-run-command.c | 19 +++
t/t0061-run-command.sh | 36 +++++
t/t4027-diff-submodule.sh | 19 +++
t/t7506-status-submodule.sh | 19 +++
10 files changed, 457 insertions(+), 50 deletions(-)
--
2.38.0.135.g90850a2211-goog
next parent reply other threads:[~2022-10-20 23:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <https://lore.kernel.org/git/20221011232604.839941-1-calvinwan@google.com/>
2022-10-20 23:25 ` Calvin Wan [this message]
2022-10-20 23:25 ` [PATCH v3 1/6] run-command: add pipe_output_fn to run_processes_parallel_opts Calvin Wan
2022-10-21 3:11 ` Ævar Arnfjörð Bjarmason
2022-10-24 17:13 ` Calvin Wan
2022-10-21 5:46 ` Junio C Hamano
2022-10-24 17:00 ` Calvin Wan
2022-10-24 19:04 ` Junio C Hamano
2022-10-25 18:51 ` Calvin Wan
2022-10-20 23:25 ` [PATCH v3 2/6] run-command: add hide_output " Calvin Wan
2022-10-21 2:54 ` Ævar Arnfjörð Bjarmason
2022-10-24 19:24 ` Calvin Wan
2022-10-25 19:32 ` Ævar Arnfjörð Bjarmason
2022-10-25 21:22 ` Calvin Wan
2022-10-20 23:25 ` [PATCH v3 3/6] submodule: strbuf variable rename Calvin Wan
2022-10-20 23:25 ` [PATCH v3 4/6] submodule: move status parsing into function Calvin Wan
2022-10-20 23:25 ` [PATCH v3 5/6] diff-lib: refactor match_stat_with_submodule Calvin Wan
2022-10-20 23:25 ` [PATCH v3 6/6] diff-lib: parallelize run_diff_files for submodules Calvin Wan
2022-10-21 1:13 ` Ævar Arnfjörð Bjarmason
2022-11-03 21:16 ` Calvin Wan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221020232532.1128326-1-calvinwan@google.com \
--to=calvinwan@google.com \
--cc=avarab@gmail.com \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
--cc=phillip.wood123@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).