git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kousik Sanagavarapu <five231003@gmail.com>
To: avarab@gmail.com
Cc: gitster@pobox.com, git@vger.kernel.org
Subject: Re: [GSoC][PATCH] commit: warn the usage of reverse_commit_list() helper
Date: Wed,  8 Feb 2023 21:23:50 +0530	[thread overview]
Message-ID: <20230208155350.186187-1-five231003@gmail.com> (raw)
In-Reply-To: <230207.86o7q52vxu.gmgdl@evledraar.gmail.com>

On Tue, 7 Feb 2023 at 23:35, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:
>
>[...]
>
> Having said that, I think the existing version is fine, and we could
> just ascribe the issue that prompted this to a one-off mistake :)

I understand it now. Thanks.

> I think if you want to pursue this, a much better improvement here would
> be to show what the user *should* do.
>
> E.g. show one code example of using the API in-place, and then the
> preferred pattern if one wants to produce a new reversed commit list,
> while retaining the original (presumably just copy_commit_list()
> followed by reverse_commit_list()).

Following the response by Junio, I think it's better off that I leave
it this way?

Thanks,
Kousik

  reply	other threads:[~2023-02-08 15:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-07 15:03 [GSoC][PATCH] commit: warn the usage of reverse_commit_list() helper Kousik Sanagavarapu
2023-02-07 17:56 ` Ævar Arnfjörð Bjarmason
2023-02-08 15:53   ` Kousik Sanagavarapu [this message]
2023-02-07 18:53 ` Junio C Hamano
2023-02-08 16:00   ` Kousik Sanagavarapu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230208155350.186187-1-five231003@gmail.com \
    --to=five231003@gmail.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).