From: ashutosh.pandeyhlr007@gmail.com
To: git@vger.kernel.org
Cc: Ashutosh Pandey <ashutosh.pandeyhlr007@gmail.com>
Subject: [PATCH] [GSoC]t7501:modernize the style of test body
Date: Tue, 21 Feb 2023 17:58:16 +0530 [thread overview]
Message-ID: <20230221122816.10236-1-ashutosh.pandeyhlr007@gmail.com> (raw)
From: Ashutosh Pandey <ashutosh.pandeyhlr007@gmail.com>
some of the test body followed the old style of test body which isn't
consistent with the new rules which is that multiple commands on one
line should be split across multiple lines this patch accomplishes that
in this test script that is t7501.
Signed-off-by: Ashutosh Pandey <ashutosh.pandeyhlr007@gmail.com>
---
t/t7501-commit-basic-functionality.sh | 20 +++++++++++++++-----
1 file changed, 15 insertions(+), 5 deletions(-)
diff --git a/t/t7501-commit-basic-functionality.sh b/t/t7501-commit-basic-functionality.sh
index fb5417d5e7..c31d6f53f4 100755
--- a/t/t7501-commit-basic-functionality.sh
+++ b/t/t7501-commit-basic-functionality.sh
@@ -33,12 +33,16 @@ test_expect_success 'setup: initial commit' '
'
test_expect_success '-m and -F do not mix' '
- git checkout HEAD file && echo >>file && git add file &&
+ git checkout HEAD file &&
+ echo >>file &&
+ git add file &&
test_must_fail git commit -m foo -m bar -F file
'
test_expect_success '-m and -C do not mix' '
- git checkout HEAD file && echo >>file && git add file &&
+ git checkout HEAD file &&
+ echo >>file &&
+ git add file &&
test_must_fail git commit -C HEAD -m illegal
'
@@ -134,18 +138,24 @@ test_expect_success 'empty commit message' '
'
test_expect_success 'template "emptyness" check does not kick in with -F' '
- git checkout HEAD file && echo >>file && git add file &&
+ git checkout HEAD file &&
+ echo >>file &&
+ git add file &&
git commit -t file -F file
'
test_expect_success 'template "emptyness" check' '
- git checkout HEAD file && echo >>file && git add file &&
+ git checkout HEAD file &&
+ echo >>file &&
+ git add file &&
test_must_fail git commit -t file 2>err &&
test_i18ngrep "did not edit" err
'
test_expect_success 'setup: commit message from file' '
- git checkout HEAD file && echo >>file && git add file &&
+ git checkout HEAD file &&
+ echo >>file &&
+ git add file &&
echo this is the commit message, coming from a file >msg &&
git commit -F msg -a
'
base-commit: d9d677b2d8cc5f70499db04e633ba7a400f64cbf
--
2.39.2
reply other threads:[~2023-02-21 12:28 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230221122816.10236-1-ashutosh.pandeyhlr007@gmail.com \
--to=ashutosh.pandeyhlr007@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).