From: Vivan Garg <gvivan6@gmail.com>
To: git@vger.kernel.org, vdye@github.com
Cc: christian.couder@gmail.com, hariom18599@gmail.com,
Vivan Garg <gvivan6@gmail.com>
Subject: [GSOC][PATCH v2 0/1] t4121: modernize test style
Date: Tue, 21 Feb 2023 14:27:52 -0700 [thread overview]
Message-ID: <20230221212753.85371-1-gvivan6@gmail.com> (raw)
In-Reply-To: <xmqq8rgqeplt.fsf@gitster.g>
Edited the commit message to add what the commit does and added a period at the end of the sentence.
Added a space after the closing bracket in the second test.
Vivan Garg (1):
t4121: modernize test style
t/t4121-apply-diffs.sh | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
Range-diff against v1:
1: 61f1ed51f4 ! 1: 77fded7759 t4121: modernize test style
@@ Commit message
Test scripts in file t4121-apply-diffs.sh are written in old style,
where the test_expect_success command and test title are written on
- separate lines
+ separate lines, therefore update the tests to adhere to the new
+ style.
Signed-off-by: Vivan Garg <gvivan6@gmail.com>
@@ t/t4121-apply-diffs.sh: test_expect_success 'setup' \
- 'check if contextually independent diffs for the same file apply' \
- '( git diff test~2 test~1 && git diff test~1 test~0 )| git apply'
+test_expect_success 'check if contextually independent diffs for the same file apply' '
-+ ( git diff test~2 test~1 && git diff test~1 test~0 )| git apply
++ ( git diff test~2 test~1 && git diff test~1 test~0 ) | git apply
+'
test_done
--
2.37.0 (Apple Git-136)
next prev parent reply other threads:[~2023-02-21 21:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 23:51 [GSOC][PATCH] t4121: modernize test style Vivan Garg
2023-02-21 17:22 ` Victoria Dye
2023-02-21 19:48 ` Vivan Garg
2023-02-21 20:21 ` Junio C Hamano
2023-02-21 21:27 ` Vivan Garg [this message]
2023-02-21 21:27 ` [GSOC][PATCH v2 1/1] " Vivan Garg
2023-02-22 5:19 ` [GSOC][PATCH] " Vivan Garg
2023-02-21 21:46 ` [GSOC][PATCH v2 0/1] " Vivan Garg
2023-02-21 21:46 ` [GSOC][PATCH v2 1/1] " Vivan Garg
2023-02-21 22:05 ` Victoria Dye
2023-02-21 22:34 ` Vivan Garg
[not found] <<20230220235121.34375-1-gvivan6@gmail.com>
2023-02-21 21:35 ` [GSOC][PATCH v2 0/1] " Vivan Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230221212753.85371-1-gvivan6@gmail.com \
--to=gvivan6@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=hariom18599@gmail.com \
--cc=vdye@github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).