git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Cc: Jeff King <peff@peff.net>
Subject: [PATCH 02/20] t5541: stop marking "used receive-pack service" test as v0 only
Date: Tue, 28 Feb 2023 15:38:55 -0800	[thread overview]
Message-ID: <20230228233913.684853-2-gitster@pobox.com> (raw)
In-Reply-To: <20230228233913.684853-1-gitster@pobox.com>

From: Jeff King <peff@peff.net>

We have a test which checks to see if a request to git-receive-pack was
made. Originally, it was checking the entire set of requests made in the
script so far, including clones, and thus it would break when run with
the v2 protocol (since that implies an extra request for fetches).

Since the previous commit, though, we are only checking the requests
made by a single push. And since there is no v2 push protocol, the test
now passes no matter what's in GIT_TEST_PROTOCOL_VERSION. We can just
run it all the time.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 t/t5541-http-push-smart.sh | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/t/t5541-http-push-smart.sh b/t/t5541-http-push-smart.sh
index ef39d14ed2..f8bf533c33 100755
--- a/t/t5541-http-push-smart.sh
+++ b/t/t5541-http-push-smart.sh
@@ -86,12 +86,7 @@ test_expect_success 'used receive-pack service' '
 	POST /smart/test_repo.git/git-receive-pack HTTP/1.1 200
 	EOF
 
-	# NEEDSWORK: If the overspecification of the expected result is reduced, we
-	# might be able to run this test in all protocol versions.
-	if test "$GIT_TEST_PROTOCOL_VERSION" = 0
-	then
-		check_access_log exp
-	fi
+	check_access_log exp
 '
 
 test_expect_success 'push to remote repository (standard) with sending Accept-Language' '
-- 
2.40.0-rc0-32-ga0f05f6840


  reply	other threads:[~2023-02-28 23:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-28 23:38 [PATCH 01/20] t5541: run "used receive-pack service" test earlier Junio C Hamano
2023-02-28 23:38 ` Junio C Hamano [this message]
2023-02-28 23:38 ` [PATCH 03/20] t5541: simplify and move "no empty path components" test Junio C Hamano
2023-02-28 23:38 ` [PATCH 04/20] t5551: drop redundant grep for Accept-Language Junio C Hamano
2023-02-28 23:38 ` [PATCH 05/20] t5551: lower-case headers in expected curl trace Junio C Hamano
2023-02-28 23:38 ` [PATCH 06/20] t5551: handle HTTP/2 when checking " Junio C Hamano
2023-02-28 23:39 ` [PATCH 07/20] t5551: stop forcing clone to run with v0 protocol Junio C Hamano
2023-02-28 23:39 ` [PATCH 08/20] t5551: handle v2 protocol when checking curl trace Junio C Hamano
2023-02-28 23:39 ` [PATCH 09/20] t5551: handle v2 protocol in upload-pack service test Junio C Hamano
2023-02-28 23:40 ` [PATCH 01/20] t5541: run "used receive-pack service" test earlier Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230228233913.684853-2-gitster@pobox.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).