From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Cc: Jeff King <peff@peff.net>
Subject: [PATCH 04/20] t5551: drop redundant grep for Accept-Language
Date: Tue, 28 Feb 2023 15:38:57 -0800 [thread overview]
Message-ID: <20230228233913.684853-4-gitster@pobox.com> (raw)
In-Reply-To: <20230228233913.684853-1-gitster@pobox.com>
From: Jeff King <peff@peff.net>
Commit b0c4adcdd7 (remote-curl: send Accept-Language header to server,
2022-07-11) added tests to make sure the header is sent via HTTP.
However, it checks in two places:
1. In the expected trace output, we check verbatim for the header and
its value.
2. Afterwards, we grep for the header again in the trace file.
This (2) is probably cargo-culted from the earlier grep for
Accept-Encoding. It is needed for the encoding because we smudge the
value of that header when doing the verbatim check; see 1a53e692af
(remote-curl: accept all encodings supported by curl, 2018-05-22).
But we don't do so for the language header, so any problem that the
"grep" would catch in (2) would already have been caught by (1).
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
t/t5551-http-fetch-smart.sh | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/t/t5551-http-fetch-smart.sh b/t/t5551-http-fetch-smart.sh
index 10b7e7cda2..29d489768e 100755
--- a/t/t5551-http-fetch-smart.sh
+++ b/t/t5551-http-fetch-smart.sh
@@ -103,10 +103,7 @@ test_expect_success 'clone http repository' '
test_cmp exp actual.smudged &&
grep "Accept-Encoding:.*gzip" actual >actual.gzip &&
- test_line_count = 2 actual.gzip &&
-
- grep "Accept-Language: ko-KR, *" actual >actual.language &&
- test_line_count = 2 actual.language
+ test_line_count = 2 actual.gzip
fi
'
--
2.40.0-rc0-32-ga0f05f6840
next prev parent reply other threads:[~2023-02-28 23:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 23:38 [PATCH 01/20] t5541: run "used receive-pack service" test earlier Junio C Hamano
2023-02-28 23:38 ` [PATCH 02/20] t5541: stop marking "used receive-pack service" test as v0 only Junio C Hamano
2023-02-28 23:38 ` [PATCH 03/20] t5541: simplify and move "no empty path components" test Junio C Hamano
2023-02-28 23:38 ` Junio C Hamano [this message]
2023-02-28 23:38 ` [PATCH 05/20] t5551: lower-case headers in expected curl trace Junio C Hamano
2023-02-28 23:38 ` [PATCH 06/20] t5551: handle HTTP/2 when checking " Junio C Hamano
2023-02-28 23:39 ` [PATCH 07/20] t5551: stop forcing clone to run with v0 protocol Junio C Hamano
2023-02-28 23:39 ` [PATCH 08/20] t5551: handle v2 protocol when checking curl trace Junio C Hamano
2023-02-28 23:39 ` [PATCH 09/20] t5551: handle v2 protocol in upload-pack service test Junio C Hamano
2023-02-28 23:40 ` [PATCH 01/20] t5541: run "used receive-pack service" test earlier Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230228233913.684853-4-gitster@pobox.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).