From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A808C77B75 for ; Tue, 18 Apr 2023 10:48:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230336AbjDRKsR (ORCPT ); Tue, 18 Apr 2023 06:48:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229833AbjDRKsP (ORCPT ); Tue, 18 Apr 2023 06:48:15 -0400 Received: from cloud.peff.net (cloud.peff.net [104.130.231.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CCE8726A8 for ; Tue, 18 Apr 2023 03:48:14 -0700 (PDT) Received: (qmail 5059 invoked by uid 109); 18 Apr 2023 10:48:14 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Tue, 18 Apr 2023 10:48:14 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 1159 invoked by uid 111); 18 Apr 2023 10:48:13 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Tue, 18 Apr 2023 06:48:13 -0400 Authentication-Results: peff.net; auth=none Date: Tue, 18 Apr 2023 06:48:13 -0400 From: Jeff King To: Taylor Blau Cc: git@vger.kernel.org, Derrick Stolee , Junio C Hamano Subject: Re: [PATCH 07/10] t/t6500-gc.sh: add additional test cases Message-ID: <20230418104813.GF508219@coredump.intra.peff.net> References: <6957e54f51759ff1b6d2469bc40c9b966635595d.1681764848.git.me@ttaylorr.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <6957e54f51759ff1b6d2469bc40c9b966635595d.1681764848.git.me@ttaylorr.com> Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Mon, Apr 17, 2023 at 04:54:33PM -0400, Taylor Blau wrote: > In the last commit, we refactored some of the tests in t6500 to make > clearer when cruft packs will and won't be generated by `git gc`. > > Add the remaining cases not covered by the previous patch into this one, > which enumerates all possible combinations of arguments that will > produce (or not produce) a cruft pack. > > This prepares us for the following commit, which will change the default > of `gc.cruftPacks` by ensuring that we understand which invocations do > and do not change as a result. I think "the following commit" is really patch 9. Patch 8 adjusts t6501 (and likewise says "like the previous commits"). It would probably make more sense to put patch 8 before patches 6 and 7. Probably not worth a re-roll on its own, but if you're doing one anyway, it should be easy to do. -Peff