From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Felipe Contreras <felipe.contreras@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] doc: doc-diff: specify date
Date: Thu, 4 May 2023 21:46:10 -0400 [thread overview]
Message-ID: <20230505014610.GA2366370@coredump.intra.peff.net> (raw)
In-Reply-To: <xmqq8re3inn4.fsf@gitster.g>
On Thu, May 04, 2023 at 06:15:59PM -0700, Junio C Hamano wrote:
> > diff --git a/Documentation/doc-diff b/Documentation/doc-diff
> > index 1694300e50..554a78a12d 100755
> > --- a/Documentation/doc-diff
> > +++ b/Documentation/doc-diff
> > @@ -153,6 +153,7 @@ render_tree () {
> > make -j$parallel -C "$tmp/worktree" \
> > $makemanflags \
> > GIT_VERSION=omitted \
> > + GIT_DATE=1970-01-01 \
> > SOURCE_DATE_EPOCH=0 \
> > DESTDIR="$tmp/installed/$dname+" \
> > install-man &&
>
> I wonder what the existing SOURCE_DATE_EPOCH was trying to do there,
> though.
It used to be necessary so that we had a reproducible build. Otherwise,
asciidoc uses the mtime of the file, and diffing two versions would have
tons of uninteresting date-differences.
After 28fde3a1 I doubt it is necessary, as the header uses $GIT_DATE
instead (it's possible the mtime may be used elsewhere, but I didn't see
any spot after grepping a built xml file. And at any rate, if it does
not produce a visible difference, that is enough for doc-diff).
-Peff
next prev parent reply other threads:[~2023-05-05 1:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-03 23:23 [PATCH] doc: doc-diff: specify date Felipe Contreras
2023-05-05 1:15 ` Junio C Hamano
2023-05-05 1:46 ` Jeff King [this message]
2023-05-05 5:55 ` Junio C Hamano
2023-05-05 21:16 ` Jeff King
2023-05-08 2:08 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230505014610.GA2366370@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).