git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andreas Herrmann <aherrmann@suse.de>
To: git@vger.kernel.org
Cc: Andreas Herrmann <aherrmann@suse.de>, Junio C Hamano <gitster@pobox.com>
Subject: [PATCH 0/3] configure.ac: misc configure fixes
Date: Wed, 19 Jul 2023 16:29:52 +0200	[thread overview]
Message-ID: <20230719145211.17854-2-aherrmann@suse.de> (raw)

Some of the configure options are not working as expected.
I first encountered this when using '--with-expat=no'.
Following patches address this.

I've also checked configure options for 'libpcre', 'openssl' (together
with 'make OPENSSL_SHA1=yes ...'), and 'tcltk'. These are working
correctly.

As a test I've run 'make test' when disabling support of a package.
I always had to use 'export GIT_SKIP_TESTS="t5801.1[4-7] t5801.31"' to
skip some failing tests. Those failed also with default build.

When disabling iconv ('configure --without-iconv') further tests are
failing. In this case I've used
'export GIT_SKIP_TESTS="t5801.1[4-7] t5801.31 \
t0028* t2082.2 t3434* t390[01]* \
t4041* t4059* t4060.8 t4201.12 t4205* t4210* t4254.[34] \
t5100* t6006* t7102.2 t8005* t9300.193 t9350*"'
to ensure that 'make test' completed without exiting early.

Andreas Herrmann (3):
  configure.ac: don't overwrite NO_EXPAT option
  configure.ac: don't overwrite NO_CURL option
  configure.ac: always save NO_ICONV to config.status

 configure.ac | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

-- 
2.41.0


             reply	other threads:[~2023-07-19 14:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-19 14:29 Andreas Herrmann [this message]
2023-07-19 14:29 ` [PATCH 1/3] configure.ac: don't overwrite NO_EXPAT option Andreas Herrmann
2023-07-19 14:29 ` [PATCH 2/3] configure.ac: don't overwrite NO_CURL option Andreas Herrmann
2023-07-19 14:29 ` [PATCH 3/3] configure.ac: always save NO_ICONV to config.status Andreas Herrmann
2023-07-19 21:35 ` [PATCH 0/3] configure.ac: misc configure fixes Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230719145211.17854-2-aherrmann@suse.de \
    --to=aherrmann@suse.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).