From: Jeff King <peff@peff.net>
To: Taylor Blau <me@ttaylorr.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] .github/workflows: add coverity action
Date: Fri, 25 Aug 2023 17:56:03 -0400 [thread overview]
Message-ID: <20230825215603.GA2400192@coredump.intra.peff.net> (raw)
In-Reply-To: <20230825213201.GD2382334@coredump.intra.peff.net>
On Fri, Aug 25, 2023 at 05:32:01PM -0400, Jeff King wrote:
> > Coverity's website provides a service accepts "builds" (which is more or
> > less the collection of '*.o' files generated during a standard build
> > with "make") as input and generates reports as output. In order to
> > generate a report, we have to first compile Git and then upload the
> > build archive to Coverity.
>
> I don't think this is quite right. You run a build with their
> "cov-build" wrapper, which does some magic. It _does_ invoke the actual
> compiler, but does some extra magic, too (I don't know the details, but
> it is running cov-translate and cov-emit on the actual source file).
>
> This maybe seems like nit-picking, but it will play into some questions
> I have on the patch itself.
I guess I never actually asked those questions, but they were: why are
you asking for some specific version of gcc since we don't really care
much about the actual compiler.
But I think you don't care about the compiler version; you were just
trying to feed enough data to install-dependencies to get it to run.
-Peff
next prev parent reply other threads:[~2023-08-25 21:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 3:34 [PATCH] .github/workflows: add coverity action Taylor Blau
2023-08-25 21:32 ` Jeff King
2023-08-25 21:56 ` Jeff King [this message]
2023-08-29 8:18 ` Johannes Schindelin
2023-08-30 0:18 ` Jeff King
2023-08-30 8:07 ` Johannes Schindelin
2023-08-30 19:03 ` Jeff King
2023-09-21 21:53 ` [PATCH v2] " Taylor Blau
2023-09-21 23:30 ` Junio C Hamano
2023-09-22 11:09 ` Johannes Schindelin
2023-09-23 6:21 ` Jeff King
2023-09-23 7:09 ` Jeff King
2023-09-23 6:10 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230825215603.GA2400192@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).