From: Jeff King <peff@peff.net>
To: phillip.wood@dunelm.org.uk
Cc: Drew DeVault <sir@cmpwn.com>, git@vger.kernel.org
Subject: Re: [PATCH] builtin/log.c: prepend "RFC" on --rfc
Date: Mon, 28 Aug 2023 13:42:59 -0400 [thread overview]
Message-ID: <20230828174259.GA3007263@coredump.intra.peff.net> (raw)
In-Reply-To: <ae22b71b-73ea-4634-bd2a-4b64082be955@gmail.com>
On Mon, Aug 28, 2023 at 05:30:36PM +0100, Phillip Wood wrote:
> I agree it sounds like a good change but if we're going to change it than I
> think we should ensure
>
> git format-patch --subject-prefix=foo --rfc
>
> and
>
> git format-patch --rfc --subject-prefix=foo
>
> give the same result. That would mean dropping rfc_callback() and using
> OPT_BOOL() instead of OPT_CALLBACK_F(). We could add the "RFC " prefix just
> before we add the re-roll suffix.
Good catch. That should also make the leak issue easier to solve, too,
as we'd hold the string (and free it) in the main cmd_format_patch()
function. This is exactly how the "reroll_count" feature works
currently.
-Peff
next prev parent reply other threads:[~2023-08-28 17:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 12:50 [PATCH] builtin/log.c: prepend "RFC" on --rfc Drew DeVault
2023-08-28 14:42 ` Jeff King
2023-08-28 14:49 ` Drew DeVault
2023-08-28 16:30 ` Phillip Wood
2023-08-28 17:42 ` Jeff King [this message]
2023-08-28 18:12 ` Junio C Hamano
2023-08-28 15:31 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230828174259.GA3007263@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=phillip.wood@dunelm.org.uk \
--cc=sir@cmpwn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).