From: Jeff King <peff@peff.net>
To: git@vger.kernel.org
Subject: [PATCH 0/22] YAUPS: Yet Another Unused Parameter Series
Date: Mon, 28 Aug 2023 17:46:04 -0400 [thread overview]
Message-ID: <20230828214604.GA3830831@coredump.intra.peff.net> (raw)
I'm back with another exciting installment of -Wunused-parameter warning
fixes. Most of these are pretty boring and obvious; the first two are
the most interesting in terms of rationale.
I promise we're closing in on the finish line here. I only have about 20
patches left after this, at which point we should be able to turn on the
warning by default for developer builds.
[01/22]: sequencer: use repository parameter in short_commit_name()
[02/22]: sequencer: mark repository argument as unused
[03/22]: ref-filter: mark unused parameters in parser callbacks
[04/22]: pack-bitmap: mark unused parameters in show_object callback
[05/22]: worktree: mark unused parameters in each_ref_fn callback
[06/22]: commit-graph: mark unused data parameters in generation callbacks
[07/22]: ls-tree: mark unused parameter in callback
[08/22]: stash: mark unused parameter in diff callback
[09/22]: trace2: mark unused us_elapsed_absolute parameters
[10/22]: trace2: mark unused config callback parameter
[11/22]: test-trace2: mark unused argv/argc parameters
[12/22]: grep: mark unused parameter in output function
[13/22]: add-interactive: mark unused callback parameters
[14/22]: negotiator/noop: mark unused callback parameters
[15/22]: worktree: mark unused parameters in noop repair callback
[16/22]: imap-send: mark unused parameters with NO_OPENSSL
[17/22]: grep: mark unused parmaeters in pcre fallbacks
[18/22]: credential: mark unused parameter in urlmatch callback
[19/22]: fetch: mark unused parameter in ref_transaction callback
[20/22]: bundle-uri: mark unused parameters in callbacks
[21/22]: gc: mark unused descriptors in scheduler callbacks
[22/22]: update-ref: mark unused parameter in parser callbacks
add-interactive.c | 8 ++++----
builtin/fetch.c | 2 +-
builtin/gc.c | 6 +++---
builtin/ls-tree.c | 3 ++-
builtin/stash.c | 2 +-
builtin/update-ref.c | 14 +++++++-------
builtin/worktree.c | 8 ++++----
bundle-uri.c | 6 +++---
commit-graph.c | 8 +++++---
credential.c | 4 ++--
grep.c | 12 +++++++-----
imap-send.c | 10 ++++++++--
negotiator/noop.c | 12 +++++++-----
pack-bitmap.c | 5 +++--
ref-filter.c | 8 +++++---
sequencer.c | 27 ++++++++++++++-------------
t/helper/test-trace2.c | 6 +++---
trace2/tr2_sysenv.c | 3 ++-
trace2/tr2_tgt_event.c | 23 +++++++++++++----------
trace2/tr2_tgt_normal.c | 20 ++++++++++++--------
worktree.c | 6 ++++--
21 files changed, 110 insertions(+), 83 deletions(-)
-Peff
next reply other threads:[~2023-08-28 21:46 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 21:46 Jeff King [this message]
2023-08-28 21:46 ` [PATCH 01/22] sequencer: use repository parameter in short_commit_name() Jeff King
2023-08-28 22:21 ` Junio C Hamano
2023-08-28 23:06 ` Taylor Blau
2023-08-29 0:48 ` Jeff King
2023-08-29 1:16 ` Junio C Hamano
2023-08-28 21:47 ` [PATCH 02/22] sequencer: mark repository argument as unused Jeff King
2023-08-28 23:24 ` Taylor Blau
2023-08-29 15:55 ` Phillip Wood
2023-08-29 23:32 ` Jeff King
2023-08-30 13:35 ` Phillip Wood
2023-08-28 21:47 ` [PATCH 03/22] ref-filter: mark unused parameters in parser callbacks Jeff King
2023-08-28 21:47 ` [PATCH 04/22] pack-bitmap: mark unused parameters in show_object callback Jeff King
2023-08-28 21:47 ` [PATCH 05/22] worktree: mark unused parameters in each_ref_fn callback Jeff King
2023-08-28 21:47 ` [PATCH 06/22] commit-graph: mark unused data parameters in generation callbacks Jeff King
2023-08-28 23:32 ` Taylor Blau
2023-08-29 0:52 ` Jeff King
2023-08-28 21:47 ` [PATCH 07/22] ls-tree: mark unused parameter in callback Jeff King
2023-08-28 21:47 ` [PATCH 08/22] stash: mark unused parameter in diff callback Jeff King
2023-08-28 21:47 ` [PATCH 09/22] trace2: mark unused us_elapsed_absolute parameters Jeff King
2023-08-28 21:47 ` [PATCH 10/22] trace2: mark unused config callback parameter Jeff King
2023-08-28 21:47 ` [PATCH 11/22] test-trace2: mark unused argv/argc parameters Jeff King
2023-08-28 21:47 ` [PATCH 12/22] grep: mark unused parameter in output function Jeff King
2023-08-28 21:48 ` [PATCH 13/22] add-interactive: mark unused callback parameters Jeff King
2023-08-28 21:48 ` [PATCH 14/22] negotiator/noop: " Jeff King
2023-08-28 21:48 ` [PATCH 15/22] worktree: mark unused parameters in noop repair callback Jeff King
2023-08-28 21:48 ` [PATCH 16/22] imap-send: mark unused parameters with NO_OPENSSL Jeff King
2023-08-28 21:48 ` [PATCH 17/22] grep: mark unused parmaeters in pcre fallbacks Jeff King
2023-08-28 21:48 ` [PATCH 18/22] credential: mark unused parameter in urlmatch callback Jeff King
2023-08-28 21:48 ` [PATCH 19/22] fetch: mark unused parameter in ref_transaction callback Jeff King
2023-08-28 21:48 ` [PATCH 20/22] bundle-uri: mark unused parameters in callbacks Jeff King
2023-08-28 21:48 ` [PATCH 21/22] gc: mark unused descriptors in scheduler callbacks Jeff King
2023-08-28 21:48 ` [PATCH 22/22] update-ref: mark unused parameter in parser callbacks Jeff King
2023-08-28 23:35 ` [PATCH 0/22] YAUPS: Yet Another Unused Parameter Series Taylor Blau
2023-08-29 23:43 ` [PATCH v2 0/22] " Jeff King
2023-08-29 23:43 ` [PATCH v2 01/22] sequencer: use repository parameter in short_commit_name() Jeff King
2023-08-30 13:24 ` Phillip Wood
2023-08-29 23:44 ` [PATCH v2 02/22] sequencer: mark repository argument as unused Jeff King
2023-08-29 23:45 ` [PATCH v2 03/22] ref-filter: mark unused parameters in parser callbacks Jeff King
2023-08-29 23:45 ` [PATCH v2 04/22] pack-bitmap: mark unused parameters in show_object callback Jeff King
2023-08-29 23:45 ` [PATCH v2 05/22] worktree: mark unused parameters in each_ref_fn callback Jeff King
2023-08-29 23:45 ` [PATCH v2 06/22] commit-graph: mark unused data parameters in generation callbacks Jeff King
2023-08-29 23:45 ` [PATCH v2 07/22] ls-tree: mark unused parameter in callback Jeff King
2023-08-29 23:45 ` [PATCH v2 08/22] stash: mark unused parameter in diff callback Jeff King
2023-08-29 23:45 ` [PATCH v2 09/22] trace2: mark unused us_elapsed_absolute parameters Jeff King
2023-08-29 23:45 ` [PATCH v2 10/22] trace2: mark unused config callback parameter Jeff King
2023-08-29 23:45 ` [PATCH v2 11/22] test-trace2: mark unused argv/argc parameters Jeff King
2023-08-29 23:45 ` [PATCH v2 12/22] grep: mark unused parameter in output function Jeff King
2023-08-29 23:45 ` [PATCH v2 13/22] add-interactive: mark unused callback parameters Jeff King
2023-08-29 23:45 ` [PATCH v2 14/22] negotiator/noop: " Jeff King
2023-08-29 23:45 ` [PATCH v2 15/22] worktree: mark unused parameters in noop repair callback Jeff King
2023-08-29 23:45 ` [PATCH v2 16/22] imap-send: mark unused parameters with NO_OPENSSL Jeff King
2023-08-29 23:45 ` [PATCH v2 17/22] grep: mark unused parmaeters in pcre fallbacks Jeff King
2023-08-29 23:45 ` [PATCH v2 18/22] credential: mark unused parameter in urlmatch callback Jeff King
2023-08-29 23:45 ` [PATCH v2 19/22] fetch: mark unused parameter in ref_transaction callback Jeff King
2023-08-29 23:45 ` [PATCH v2 20/22] bundle-uri: mark unused parameters in callbacks Jeff King
2023-08-29 23:45 ` [PATCH v2 21/22] gc: mark unused descriptors in scheduler callbacks Jeff King
2023-08-29 23:45 ` [PATCH v2 22/22] update-ref: mark unused parameter in parser callbacks Jeff King
2023-08-30 1:00 ` [PATCH v2 0/22] Yet Another Unused Parameter Series Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230828214604.GA3830831@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).