From: Jeff King <peff@peff.net>
To: git@vger.kernel.org
Cc: Jeff Hostetler <jeffhostetler@github.com>,
Eric DeCosta <edecosta@mathworks.com>
Subject: [PATCH 0/8] fsmonitor unused parameter cleanups
Date: Mon, 18 Sep 2023 18:29:08 -0400 [thread overview]
Message-ID: <20230918222908.GA2659096@coredump.intra.peff.net> (raw)
Here are a few cleanups of the fsmonitor code to remove or annotate
unused parameters (working towards my goal of making us compile clean
with -Wunused-parameter). I think they should all be pretty
non-controversial, but I'm cc-ing folks active in the area in case patch
2 steps on the toes of any unpublished works in progress.
[1/8]: fsmonitor: prefer repo_git_path() to git_pathdup()
[2/8]: fsmonitor/win32: drop unused parameters
[3/8]: fsmonitor: mark some maybe-unused parameters
[4/8]: fsmonitor/win32: mark unused parameter in fsm_os__incompatible()
[5/8]: fsmonitor: mark unused parameters in stub functions
[6/8]: fsmonitor/darwin: mark unused parameters in system callback
[7/8]: fsmonitor: mark unused hashmap callback parameters
[8/8]: run-command: mark unused parameters in start_bg_wait callbacks
builtin/fsmonitor--daemon.c | 10 ++++++----
compat/fsmonitor/fsm-health-darwin.c | 8 ++++----
compat/fsmonitor/fsm-ipc-win32.c | 2 +-
compat/fsmonitor/fsm-listen-darwin.c | 4 ++--
compat/fsmonitor/fsm-listen-win32.c | 24 ++++++++++--------------
compat/fsmonitor/fsm-path-utils-win32.c | 7 ++++---
compat/fsmonitor/fsm-settings-win32.c | 2 +-
fsmonitor-ipc.c | 10 +++++-----
fsmonitor-settings.c | 3 ++-
t/helper/test-simple-ipc.c | 3 ++-
10 files changed, 37 insertions(+), 36 deletions(-)
-Peff
next reply other threads:[~2023-09-18 22:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 22:29 Jeff King [this message]
2023-09-18 22:29 ` [PATCH 1/8] fsmonitor: prefer repo_git_path() to git_pathdup() Jeff King
2023-09-18 22:30 ` [PATCH 2/8] fsmonitor/win32: drop unused parameters Jeff King
2023-09-18 22:31 ` [PATCH 3/8] fsmonitor: mark some maybe-unused parameters Jeff King
2023-09-18 22:32 ` [PATCH 4/8] fsmonitor/win32: mark unused parameter in fsm_os__incompatible() Jeff King
2023-09-18 22:32 ` [PATCH 5/8] fsmonitor: mark unused parameters in stub functions Jeff King
2023-09-18 22:32 ` [PATCH 6/8] fsmonitor/darwin: mark unused parameters in system callback Jeff King
2023-09-18 22:33 ` [PATCH 7/8] fsmonitor: mark unused hashmap callback parameters Jeff King
2023-09-18 22:33 ` [PATCH 8/8] run-command: mark unused parameters in start_bg_wait callbacks Jeff King
2023-09-19 13:34 ` [PATCH 0/8] fsmonitor unused parameter cleanups Jeff Hostetler
2023-09-19 18:09 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230918222908.GA2659096@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=edecosta@mathworks.com \
--cc=git@vger.kernel.org \
--cc=jeffhostetler@github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).