From: Jacob Stopak <jacob@initialcommit.io>
To: git@vger.kernel.org
Cc: Jacob Stopak <jacob@initialcommit.io>,
Junio C Hamano <gitster@pobox.com>,
Dragan Simic <dsimic@manjaro.org>,
Kristoffer Haugsbakk <code@khaugsbakk.name>
Subject: [PATCH v2 0/3] bugreport: include +i in outfile suffix as needed
Date: Sat, 14 Oct 2023 20:42:34 -0700 [thread overview]
Message-ID: <20231015034238.100675-1-jacob@initialcommit.io> (raw)
In-Reply-To: <20231014040101.8333-1-jacob@initialcommit.io>
Update git bugreport to allow creation of multiple bugreports with
default settings during a given minute interval.
Address several edge cases where users might run git bugreport multiple
times within a minute and expect multiple reports to be created.
Handle these cases by checking to see if a file with the default
timestamped filename already exists, and if so, appending a '+1' value
to the filename suffix. Keep doing so until a unique filename is reached
or '+9' is reached. At this point, if uniqueness is still not found,
the previous error that a file with the given name already exists.
If the --diagnose flag is supplied, apply the same '+i' incremented
filename suffix to the diagnostics zip file.
Reorder the code block that creates the diagnostics zip file so it isn't
created in the event the bugreport itself isn't created due to an error.
Jacob Stopak (3):
bugreport: include +i in outfile suffix as needed
bugreport: match diagnostics filename with report
bugreport: don't create --diagnose zip w/o report
builtin/bugreport.c | 54 ++++++++++++++++++++++++++++++---------------
1 file changed, 36 insertions(+), 18 deletions(-)
base-commit: 493f4622739e9b64f24b465b21aa85870dd9dc09
--
2.42.0.298.gd89efca819.dirty
next prev parent reply other threads:[~2023-10-15 3:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-14 4:01 [PATCH] bugreport: add 'seconds' to default outfile name Jacob Stopak
2023-10-14 10:35 ` Kristoffer Haugsbakk
2023-10-14 16:27 ` Junio C Hamano
2023-10-14 16:33 ` Dragan Simic
2023-10-14 17:45 ` Junio C Hamano
2023-10-14 17:52 ` Dragan Simic
2023-10-15 3:07 ` Jacob Stopak
2023-10-15 3:13 ` Dragan Simic
2023-10-15 3:01 ` Jacob Stopak
2023-10-15 17:06 ` Junio C Hamano
2023-10-15 3:42 ` Jacob Stopak [this message]
2023-10-15 3:42 ` [PATCH v2 1/3] bugreport: include +i in outfile suffix as needed Jacob Stopak
2023-10-15 17:36 ` Junio C Hamano
2023-10-16 21:40 ` [PATCH v3 0/1] " Jacob Stopak
2023-10-16 21:40 ` [PATCH v3 1/1] " Jacob Stopak
2023-10-16 22:55 ` Junio C Hamano
2023-10-17 3:17 ` Jacob Stopak
2023-10-21 0:39 ` Junio C Hamano
2023-10-26 21:19 ` Emily Shaffer
2023-10-27 6:34 ` Jacob Stopak
2024-01-06 4:54 ` Jacob Stopak
2023-10-15 3:42 ` [PATCH v2 2/3] bugreport: match diagnostics filename with report Jacob Stopak
2023-10-15 3:42 ` [PATCH v2 3/3] bugreport: don't create --diagnose zip w/o report Jacob Stopak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231015034238.100675-1-jacob@initialcommit.io \
--to=jacob@initialcommit.io \
--cc=code@khaugsbakk.name \
--cc=dsimic@manjaro.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).