[PATCH] git-push: more visibility for -q option

[PATCH] git-push: more visibility for -q option

[Michal Suchanek]

The -v option listed at the top as option al parameter while -q is not.

List -q alongside -v.

Signed-off-by: Michal Suchanek <msuchanek@suse.de>
---
 Documentation/git-push.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/git-push.txt b/Documentation/git-push.txt
index 5b4edaf4a8..003bc7d9ce 100644
--- a/Documentation/git-push.txt
+++ b/Documentation/git-push.txt
@@ -10,7 +10,7 @@ SYNOPSIS
 --------
 [verse]
 'git push' [--all | --branches | --mirror | --tags] [--follow-tags] [--atomic] [-n | --dry-run] [--receive-pack=<git-receive-pack>]
-	   [--repo=<repository>] [-f | --force] [-d | --delete] [--prune] [-v | --verbose]
+	   [--repo=<repository>] [-f | --force] [-d | --delete] [--prune] [-q | --quiet] [-v | --verbose]
 	   [-u | --set-upstream] [-o <string> | --push-option=<string>]
 	   [--[no-]signed|--signed=(true|false|if-asked)]
 	   [--force-with-lease[=<refname>[:<expect>]] [--force-if-includes]]
-- 
2.42.0

Re: [PATCH] git-push: more visibility for -q option

[Eric Sunshine]

On Fri, Oct 20, 2023 at 2:46 PM Michal Suchanek <msuchanek@suse.de> wrote:
> The -v option listed at the top as option al parameter while -q is not.

s/option al/optional/

> List -q alongside -v.
>
> Signed-off-by: Michal Suchanek <msuchanek@suse.de>

Re: [PATCH] git-push: more visibility for -q option

[Junio C Hamano]

Michal Suchanek <msuchanek@suse.de> writes:

> The -v option listed at the top as option al parameter while -q is not.

"as option al parameter" - ECANNOTPARSE.  Probably

    The `-v` option is shown in the SYNOPSIS section near the top,
    but `-q` is not shown anywhere there.

or something, I think.  I agree showing it next to "-v" would make
the most sense.

>
> List -q alongside -v.
>
> Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> ---
>  Documentation/git-push.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/git-push.txt b/Documentation/git-push.txt
> index 5b4edaf4a8..003bc7d9ce 100644
> --- a/Documentation/git-push.txt
> +++ b/Documentation/git-push.txt
> @@ -10,7 +10,7 @@ SYNOPSIS
>  --------
>  [verse]
>  'git push' [--all | --branches | --mirror | --tags] [--follow-tags] [--atomic] [-n | --dry-run] [--receive-pack=<git-receive-pack>]
> -	   [--repo=<repository>] [-f | --force] [-d | --delete] [--prune] [-v | --verbose]
> +	   [--repo=<repository>] [-f | --force] [-d | --delete] [--prune] [-q | --quiet] [-v | --verbose]

Yup, the change makes sense.  We may want to wrap the first line to
a more reasonable length in a separate commit, and when that
happens, we probably would want to start [-v] [-q] on a separate
line as well, but for now this would do.

Re: [PATCH] git-push: more visibility for -q option

[Michal Suchánek]

Hello,

On Fri, Oct 20, 2023 at 01:08:04PM -0700, Junio C Hamano wrote:
> Michal Suchanek <msuchanek@suse.de> writes:
> 
> > The -v option listed at the top as option al parameter while -q is not.
> 
> "as option al parameter" - ECANNOTPARSE.  Probably
> 
>     The `-v` option is shown in the SYNOPSIS section near the top,
>     but `-q` is not shown anywhere there.
> 
> or something, I think.  I agree showing it next to "-v" would make
> the most sense.

when rebasing to current master I see this is already applied with the
fixed commit message, great!

Thanks

Michal

> 
> >
> > List -q alongside -v.
> >
> > Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> > ---
> >  Documentation/git-push.txt | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/git-push.txt b/Documentation/git-push.txt
> > index 5b4edaf4a8..003bc7d9ce 100644
> > --- a/Documentation/git-push.txt
> > +++ b/Documentation/git-push.txt
> > @@ -10,7 +10,7 @@ SYNOPSIS
> >  --------
> >  [verse]
> >  'git push' [--all | --branches | --mirror | --tags] [--follow-tags] [--atomic] [-n | --dry-run] [--receive-pack=<git-receive-pack>]
> > -	   [--repo=<repository>] [-f | --force] [-d | --delete] [--prune] [-v | --verbose]
> > +	   [--repo=<repository>] [-f | --force] [-d | --delete] [--prune] [-q | --quiet] [-v | --verbose]
> 
> Yup, the change makes sense.  We may want to wrap the first line to
> a more reasonable length in a separate commit, and when that
> happens, we probably would want to start [-v] [-q] on a separate
> line as well, but for now this would do.
>