From: Michael McClimon <michael@mcclimon.org>
To: git@vger.kernel.org
Cc: Michael McClimon <michael@mcclimon.org>
Subject: [RFC PATCH 1/2] patch-ids: add const modifier to commit
Date: Sat, 21 Oct 2023 22:27:59 -0400 [thread overview]
Message-ID: <20231022022800.69219-2-michael@mcclimon.org> (raw)
In-Reply-To: <20231022022800.69219-1-michael@mcclimon.org>
These aren't modified by these functions, and I want to use them
somewhere where the commit is in fact a const.
Signed-off-by: Michael McClimon <michael@mcclimon.org>
---
patch-ids.c | 4 ++--
patch-ids.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/patch-ids.c b/patch-ids.c
index c3e1a0dd..ecfd7ba0 100644
--- a/patch-ids.c
+++ b/patch-ids.c
@@ -6,13 +6,13 @@
#include "hex.h"
#include "patch-ids.h"
-static int patch_id_defined(struct commit *commit)
+static int patch_id_defined(const struct commit *commit)
{
/* must be 0 or 1 parents */
return !commit->parents || !commit->parents->next;
}
-int commit_patch_id(struct commit *commit, struct diff_options *options,
+int commit_patch_id(const struct commit *commit, struct diff_options *options,
struct object_id *oid, int diff_header_only)
{
if (!patch_id_defined(commit))
diff --git a/patch-ids.h b/patch-ids.h
index 490d7393..3f61d88a 100644
--- a/patch-ids.h
+++ b/patch-ids.h
@@ -19,7 +19,7 @@ struct patch_ids {
struct diff_options diffopts;
};
-int commit_patch_id(struct commit *commit, struct diff_options *options,
+int commit_patch_id(const struct commit *commit, struct diff_options *options,
struct object_id *oid, int);
int init_patch_ids(struct repository *, struct patch_ids *);
int free_patch_ids(struct patch_ids *);
--
2.42.0.424.gceadf0f3
next prev parent reply other threads:[~2023-10-22 2:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-22 2:27 [RFC PATCH 0/2] pretty: add %I formatting for patch-id Michael McClimon
2023-10-22 2:27 ` Michael McClimon [this message]
2023-10-22 2:28 ` [RFC PATCH 2/2] pretty: add 'I' placeholder " Michael McClimon
2023-10-25 8:44 ` [RFC PATCH 0/2] pretty: add %I formatting " Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231022022800.69219-2-michael@mcclimon.org \
--to=michael@mcclimon.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).