git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: "Michal Suchánek" <msuchanek@suse.de>
Cc: "Torsten Bögershausen" <tboegi@web.de>,
	"Alexander Mills" <alexander.d.mills@gmail.com>,
	git@vger.kernel.org
Subject: Re: please add link / url to remote - when - git push
Date: Mon, 30 Oct 2023 05:39:19 -0400	[thread overview]
Message-ID: <20231030093919.GF84866@coredump.intra.peff.net> (raw)
In-Reply-To: <20231030093023.GG6241@kitsune.suse.cz>

On Mon, Oct 30, 2023 at 10:30:23AM +0100, Michal Suchánek wrote:

> > > On the other hand, option to NOT display those remote messages is also
> > > missing. At least with git 2.35 they are displayed even when -q argument
> > > is given.
> > 
> > That is also up to GitHub to fix on the server side:
> > 
> >   https://lore.kernel.org/git/20230519090559.GA3515410@coredump.intra.peff.net/
> 
> If the server did not reject the push the messages it returns could be
> considered informational.

Hmm, yeah, I could perhaps buy that line of argument. Though it's
possible they are "warnings" of the sort that should still be emitted
with "--quiet"; really only the server knows. And note that even "reject
the push" is not necessarily all-or-nothing. The server may accept some
subset of the refs.

But...

> Not sure if the final status of the push is available or of the
> rejection is only noted in these messages, though.

Yes, this is a problem. Those messages are streamed out as we receive
them from the server, and before we get any status report back. I don't
think we'd want to buffer them, as they can be arbitrarily large (and
may even be progress reports that are meant to be shown in real-time).

-Peff

  reply	other threads:[~2023-10-30  9:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-29 23:15 please add link / url to remote - when - git push Alexander Mills
2023-10-30  6:36 ` Torsten Bögershausen
2023-10-30  6:55   ` Junio C Hamano
2023-10-30  8:52   ` Michal Suchánek
2023-10-30  9:06     ` Jeff King
2023-10-30  9:30       ` Michal Suchánek
2023-10-30  9:39         ` Jeff King [this message]
2023-10-30  9:45           ` Michal Suchánek
2023-10-30  9:54             ` Jeff King
2023-10-30 10:42               ` Michal Suchánek
2023-10-30 15:55 ` Taylor Blau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231030093919.GF84866@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=alexander.d.mills@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=msuchanek@suse.de \
    --cc=tboegi@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).