From: Jeff King <peff@peff.net>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: rsbecker@nexbridge.com, Git List <git@vger.kernel.org>
Subject: Re: Request for Help - Too many perl arguments as of 2.43.0-rc0
Date: Sun, 5 Nov 2023 01:34:48 -0400 [thread overview]
Message-ID: <20231105051615.GA1515359@coredump.intra.peff.net> (raw)
In-Reply-To: <CAPig+cTy7Mq1xhTtssoUDpwrCNB_65q4VjK902jOpJ4469_tLw@mail.gmail.com>
On Sat, Nov 04, 2023 at 08:11:01PM -0400, Eric Sunshine wrote:
> > Hmm. With compilation, we split the audience of "developers" vs "people
> > who just want to build the program", and we crank up the number and
> > severity of warning checks for the former. We could do the same here for
> > tests. I.e., turn off test linting by default and re-enable it for
> > DEVELOPER=1.
>
> My knee-jerk reaction is that this would move us in the wrong
> direction since it is probable that most drive-by contributors won't
> have DEVELOPER=1 set, yet they are the ones who are likely to benefit
> most from test script linting (which is not to say that it doesn't
> help seasoned contributors, as well).
Yeah, that's a good point. If the linting is not causing frequent
headaches (and I don't think it is), then we are better to leave it on
by default.
-Peff
prev parent reply other threads:[~2023-11-05 5:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 19:03 Request for Help - Too many perl arguments as of 2.43.0-rc0 rsbecker
2023-11-03 20:52 ` Eric Sunshine
2023-11-03 21:30 ` rsbecker
2023-11-03 21:50 ` Eric Sunshine
2023-11-03 22:04 ` rsbecker
2023-11-04 6:36 ` Eric Sunshine
2023-11-04 7:59 ` Junio C Hamano
2023-11-04 23:50 ` Eric Sunshine
2023-11-04 13:49 ` Jeff King
2023-11-04 14:55 ` rsbecker
2023-11-05 0:11 ` Eric Sunshine
2023-11-05 5:34 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231105051615.GA1515359@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=rsbecker@nexbridge.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).