From: "H.Merijn Brand" <linux@tux.freedom.nl>
To: Bagas Sanjaya <bagasdotme@gmail.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: Fix git-send-email.perl w.r.t. recent Getopt::Long update
Date: Sat, 25 Nov 2023 10:45:22 +0100 [thread overview]
Message-ID: <20231125104211.5b7fe0be@pc09> (raw)
In-Reply-To: <ZWFaZcgzwEP13geI@archie.me>
[-- Attachment #1: Type: text/plain, Size: 1497 bytes --]
On Sat, 25 Nov 2023 09:22:29 +0700, Bagas Sanjaya <bagasdotme@gmail.com> wrote:
> On Fri, Nov 24, 2023 at 10:39:32AM +0100, H.Merijn Brand wrote:
> > Patch attached
>
> Do not send patches as attachments; send them inline instead. See
> Documentation/SubmittingPatches for more info (hint: send patches
> with git-send-email(1)).
As I am used to PR's by now on all OSS projects I am involved in, or
use git commits or merges directly on the repo, I *never* use
format-patch and/or send-email.
These docs - yes I read them - do not offer a concise cut-n-paste
example for people like me. In order to have my relative simple patch
submitted (I already had the PR ready, but that came with a huge
warning that PR's are not accepted) I did it the way I did it. Now I
need to read and learn two new commands> I don't think that is very
user-friendly, but that might be just me.
Ironically, this patch is about the mail part of git.
I suggest adding a small example like
# Create the patch basics
$ git format-patch --cover-letter -M origin/master -o outgoing
# Fix the subject
$ $VISUAL outgoing/0000-cover-letter.patch
# Send the mail
$ git send-email --to=git@vger.kernel.org outgoing/*
> Thanks.
--
H.Merijn Brand https://tux.nl Perl Monger http://amsterdam.pm.org/
using perl5.00307 .. 5.37 porting perl5 on HP-UX, AIX, and Linux
https://tux.nl/email.html http://qa.perl.org https://www.test-smoke.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-11-25 9:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-24 9:39 Fix git-send-email.perl w.r.t. recent Getopt::Long update H.Merijn Brand
2023-11-25 2:22 ` Bagas Sanjaya
2023-11-25 9:45 ` H.Merijn Brand [this message]
2023-11-25 12:28 ` Dragan Simic
2023-11-27 21:38 ` Jeff King
2023-11-27 0:58 ` Junio C Hamano
2023-11-27 8:38 ` H.Merijn Brand
2023-11-28 2:07 ` Todd Zullinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231125104211.5b7fe0be@pc09 \
--to=linux@tux.freedom.nl \
--cc=bagasdotme@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).