git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shreyansh Paliwal <shreyanshpaliwalcmsmn@gmail.com>
To: git@vger.kernel.org
Cc: five231003@gmail.com, gitster@pobox.com,
	shreyp135 <shreyanshpaliwalcmsmn@gmail.com>,
	Shreyansh Paliwal <Shreyanshpaliwalcmsmn@gmail.com>
Subject: [PATCH v2] test-lib-functions.sh: fix test_grep fail message wording
Date: Sun,  3 Dec 2023 22:47:59 +0530	[thread overview]
Message-ID: <20231203171956.771-1-shreyanshpaliwalcmsmn@gmail.com> (raw)
In-Reply-To: <CAPYXD64yCuMta_iGE+ZwgxrJn0U5shcwcB9jaiNkFhvff=R7MQ@mail.gmail.com>

From: shreyp135 <shreyanshpaliwalcmsmn@gmail.com>

In the recent commit
2e87fca189 (test framework: further deprecate test_i18ngrep, 2023-10-31),
the test_i18ngrep() function was deprecated.

So if a test employing this function fails,
the error messages may be confusing due to wording issues.

It's important to address these wording changes to ensure smooth transitions
for developers adapting to the deprecation of test_i18ngrep,
and to maintain the effectiveness of the testing process.

Signed-off-by: Shreyansh Paliwal <Shreyanshpaliwalcmsmn@gmail.com>
---
 t/test-lib-functions.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh
index 9c3cf12b26..8737c95e0c 100644
--- a/t/test-lib-functions.sh
+++ b/t/test-lib-functions.sh
@@ -1277,7 +1277,7 @@ test_grep () {
 	if test $# -lt 2 ||
 	   { test "x!" = "x$1" && test $# -lt 3 ; }
 	then
-		BUG "too few parameters to test_i18ngrep"
+		BUG "too few parameters to test_grep"
 	fi
 
 	if test "x!" = "x$1"
-- 
2.43.0.1


  parent reply	other threads:[~2023-12-03 17:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-02 17:24 [Patch] test-lib-functions.sh : change test_i18ngrep to test_grep Shreyansh Paliwal
2023-12-03  8:22 ` Kousik Sanagavarapu
2023-12-03 13:19   ` Junio C Hamano
2023-12-03 17:17 ` Shreyansh Paliwal [this message]
2023-12-04 18:43   ` [PATCH v2] test-lib-functions.sh: fix test_grep fail message wording Kousik Sanagavarapu
2023-12-17 15:07   ` Shreyansh Paliwal
2023-12-18  0:51     ` Eric Sunshine
2023-12-18 16:34       ` Junio C Hamano
2023-12-18 18:47         ` Junio C Hamano
2023-12-18 18:55           ` Eric Sunshine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231203171956.771-1-shreyanshpaliwalcmsmn@gmail.com \
    --to=shreyanshpaliwalcmsmn@gmail.com \
    --cc=five231003@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).