git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Lohmann <mial.lohmann@gmail.com>
To: phillip.wood123@gmail.com
Cc: Johannes.Schindelin@gmx.de, git@vger.kernel.org,
	mi.al.lohmann@gmail.com, mial.lohmann@gmail.com,
	phillip.wood@dunelm.org.uk
Subject: Re: [PATCH] rebase-interactive: show revert option and add single letter shortcut
Date: Mon, 18 Dec 2023 18:26:45 +0100	[thread overview]
Message-ID: <20231218172645.74133-1-mi.al.lohmann@gmail.com> (raw)
In-Reply-To: <20231218170912.73535-1-mi.al.lohmann@gmail.com>

Hi Phillip

> Thanks for the patch, I'm wondering why you want to revert a commit
> when you're rebasing.

I know this is probably not going to be the most used command, but I
think (depending on your workflow) it can be as important as e.g.
`reset` or `update-ref`

> I think it would be helpful to explain that in the commit message. In
> particular why it is necessary to revert a commit rather than simply
> dropping it (presumably you're using rebase to do something more that
> just rework a series of commits)

I gave two examples - maybe they can give a hint on why this actually
can be a useful feature. Over the last few years I might have only
wanted to do this twice or so, but I know that I read through the help
string at least once to see how to do a revert.

Cheers!

P.S. I am sorry I missed the "v2" in the previous patch - I am still
learning how to deal with the mailing list...

  reply	other threads:[~2023-12-18 17:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-18  6:53 Why is `revert` undocumented in interactive rebase todo help? Michael Lohmann
2023-12-18 10:53 ` Johannes Schindelin
2023-12-18 15:23   ` [PATCH] rebase-interactive: show revert option and add single letter shortcut Michael Lohmann
2023-12-18 16:32     ` Phillip Wood
2023-12-18 17:09       ` Michael Lohmann
2023-12-18 17:26         ` Michael Lohmann [this message]
2023-12-18 18:43         ` Junio C Hamano
2023-12-20  8:53           ` Michael Lohmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231218172645.74133-1-mi.al.lohmann@gmail.com \
    --to=mial.lohmann@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=mi.al.lohmann@gmail.com \
    --cc=phillip.wood123@gmail.com \
    --cc=phillip.wood@dunelm.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).