From: Illia Bobyr <illia.bobyr@gmail.com>
To: git@vger.kernel.org
Cc: Taylor Blau <me@ttaylorr.com>
Subject: [PATCH v3] rebase: clarify --reschedule-failed-exec default
Date: Thu, 4 Jan 2024 17:14:24 -0800 [thread overview]
Message-ID: <20240105011424.1443732-1-illia.bobyr@gmail.com> (raw)
In-Reply-To: <ZZcE/Kw24YKlqSOT@nand.local>
Sorry, I did not actually include the change in v2.
Still learning how to use git send-email.
On Thu, Jan 04, 2024 at 11:20:28AM -0800, Taylor Blau wrote:
> [...]
>
> > +Recording this option for the whole rebase is a convenience feature. Otherwise
> > +an explicit `--no-reschedule-failed-exec` at the start would be overridden by
> > +the presence of a `rebase.rescheduleFailedExec=true` configuration when `git
> > +rebase --continue` is invoked. Currently, you can not, pass
> > +`--[no-]reschedule-failed-exec` to `git rebase --continue`.
>
> The last sentence was a bit confusing to me. I assume you meant
>
> Currently, you cannot pass `--[no-]reschedule-failed-exec` [...]
>
> without the comma between "pass" and "`--[no]reschedule-failed-exect`",
> and replacing "can not" with "cannot".
Applied.
Thank you for reviewing!
next prev parent reply other threads:[~2024-01-05 1:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-04 8:06 [PATCH] rebase: clarify --reschedule-failed-exec default Illia Bobyr
2024-01-04 19:20 ` Taylor Blau
2024-01-05 1:14 ` Illia Bobyr [this message]
2024-01-05 1:14 ` [PATCH v3] " Illia Bobyr
2024-01-05 17:11 ` Taylor Blau
2024-01-05 0:42 ` [PATCH v2] " Illia Bobyr
2024-01-05 0:42 ` Illia Bobyr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240105011424.1443732-1-illia.bobyr@gmail.com \
--to=illia.bobyr@gmail.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).