git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Lohmann <mi.al.lohmann@gmail.com>
To: gitster@pobox.com
Cc: git@vger.kernel.org, mi.al.lohmann@gmail.com, phillip.wood123@gmail.com
Subject: Re: [RFC PATCH] `log --merge` also for rebase/cherry pick/revert
Date: Fri, 12 Jan 2024 22:06:50 +0100	[thread overview]
Message-ID: <20240112210650.5455-1-mi.al.lohmann@gmail.com> (raw)
In-Reply-To: <xmqqr0im9ub9.fsf@gitster.g>

> > tells us. Indeed there HEAD and CHERRY_PICK_HEAD may not share a
> > common ancestor. As I say I've not used "git log --merge" so maybe I'm
> > missing the reason why it would be useful when cherry-picking or
> > rebasing.
> 
> Good question.  It is the whole point of cherry-pick that
> CHERRY_PICK_HEAD and the current HEAD may not have any meaningful
> ancestry relationship, so yes, it is questionable to use the same
> logic for "log --merge" between HEAD...CHERRY_PICK_HEAD, while using
> HEAD...MERGE_HEAD does make perfect sense.

I tried to say it in [1]: a merge also does not need a common ancestor! Try it:

   git init test
   cd test
   echo something > README.md
   git add --all
   git commit -m "initial commit"
   git remote add origin_git git://git.kernel.org/pub/scm/git/git.git
   git fetch origin_git master     # obviously no common ancestor
   git merge --allow-unrelated-histories origin_git/master
   # merge conflict
   git log --merge    # Still loggs all the conflicting commits

So indeed the command that Phillip wrote is not equivalent and the existing
logic already can deal with unrelated histories. Or am I misunderstanding?

Michael

[1] https://lore.kernel.org/git/20240112150346.73735-1-mi.al.lohmann@gmail.com/

      reply	other threads:[~2024-01-12 21:07 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-11 23:33 [RFC PATCH] `log --merge` also for rebase/cherry pick/revert Michael Lohmann
2024-01-12  0:15 ` Junio C Hamano
2024-01-12 15:50   ` [PATCH v2 1/2] revision: ensure MERGE_HEAD is a ref in prepare_show_merge Michael Lohmann
2024-01-12 15:50     ` [PATCH v2 2/2] revision: Implement `git log --merge` also for rebase/cherry_pick/revert Michael Lohmann
2024-01-12 20:10     ` [PATCH v2 1/2] revision: ensure MERGE_HEAD is a ref in prepare_show_merge Junio C Hamano
2024-01-15 11:36       ` Patrick Steinhardt
2024-01-15 17:19         ` Junio C Hamano
2024-01-17  8:14       ` [PATCH v3 " Michael Lohmann
2024-01-17  8:14         ` [PATCH v3 2/2] revision: Implement `git log --merge` also for rebase/cherry_pick/revert Michael Lohmann
2024-01-17  9:19           ` Full disclosure Michael Lohmann
2024-01-17  9:58             ` Christian Couder
2024-01-17 17:41               ` Michael Lohmann
2024-01-21  0:41                 ` Ruben Safir
2024-01-17 18:33             ` Junio C Hamano
2024-01-24  7:06           ` [PATCH v3 2/2] revision: Implement `git log --merge` also for rebase/cherry_pick/revert Elijah Newren
2024-01-24 17:19             ` Johannes Sixt
2024-01-24 19:46               ` Junio C Hamano
2024-01-24 22:06                 ` Johannes Sixt
2024-01-24 22:13                   ` Junio C Hamano
2024-02-09 23:54               ` Junio C Hamano
2024-01-24 17:34             ` Junio C Hamano
2024-02-10 23:35         ` [PATCH v4 0/2] Implement `git log --merge` also for rebase/cherry-pick/revert Philippe Blain
2024-02-10 23:35           ` [PATCH v4 1/2] revision: ensure MERGE_HEAD is a ref in prepare_show_merge Philippe Blain
2024-02-10 23:35           ` [PATCH v4 2/2] revision: implement `git log --merge` also for rebase/cherry-pick/revert Philippe Blain
2024-02-11  8:34             ` Johannes Sixt
2024-02-11 16:43               ` Philippe Blain
2024-02-11 17:59                 ` Johannes Sixt
2024-02-12 18:27                   ` Junio C Hamano
2024-02-12 11:02             ` Phillip Wood
2024-02-13 13:27               ` Philippe Blain
2024-02-14 11:02                 ` Phillip Wood
2024-02-13  8:33             ` Jean-Noël Avila
2024-02-13 13:14               ` Philippe Blain
2024-02-25 21:56           ` [PATCH v5 0/2] Implement " Philippe Blain
2024-02-25 21:56             ` [PATCH v5 1/2] revision: ensure MERGE_HEAD is a ref in prepare_show_merge Philippe Blain
2024-02-26 17:22               ` Jean-Noël Avila
2024-02-26 17:54                 ` Philippe Blain
2024-02-25 21:56             ` [PATCH v5 2/2] revision: implement `git log --merge` also for rebase/cherry-pick/revert Philippe Blain
2024-02-26  4:35               ` Junio C Hamano
2024-02-26 17:43                 ` Philippe Blain
2024-02-27 14:00             ` [PATCH v5 0/2] Implement " Phillip Wood
2024-02-27 18:30               ` Junio C Hamano
2024-02-28 13:54             ` [PATCH v6 " Philippe Blain
2024-02-28 13:54               ` [PATCH v6 1/2] revision: ensure MERGE_HEAD is a ref in prepare_show_merge Philippe Blain
2024-02-28 13:54               ` [PATCH v6 2/2] revision: implement `git log --merge` also for rebase/cherry-pick/revert Philippe Blain
2024-02-28 14:40               ` [PATCH v6 0/2] Implement " phillip.wood123
2024-03-02 15:35                 ` Philippe Blain
2024-01-12  7:35 ` [RFC PATCH] `log --merge` also for rebase/cherry pick/revert Johannes Sixt
2024-01-12  7:59   ` Johannes Sixt
2024-01-12 20:18   ` Junio C Hamano
2024-01-12 11:01 ` phillip.wood123
2024-01-12 15:03   ` Michael Lohmann
2024-01-12 21:14     ` Junio C Hamano
2024-01-15 10:48     ` Phillip Wood
2024-01-12 20:21   ` Junio C Hamano
2024-01-12 21:06     ` Michael Lohmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240112210650.5455-1-mi.al.lohmann@gmail.com \
    --to=mi.al.lohmann@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=phillip.wood123@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).