git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christian Couder <christian.couder@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>,
	Patrick Steinhardt <ps@pks.im>, John Cai <johncai86@gmail.com>,
	Christian Couder <christian.couder@gmail.com>
Subject: [PATCH 0/3] rev-list: allow missing tips with --missing
Date: Thu,  1 Feb 2024 12:58:06 +0100	[thread overview]
Message-ID: <20240201115809.1177064-1-christian.couder@gmail.com> (raw)

A recent patch series, kn/rev-list-missing-fix [1] extended the
`--missing` option in git-rev-list(1) to support commit objects.

Unfortunately, git-rev-list(1) with `--missing` set to something other
than 'error' still fails, usually with a "fatal: bad object <oid>"
error message, when a missing object is passed as an argument.

This patch series removes this limitation and when using
`--missing=print` allows all missing objects to be printed including
those that are passed as arguments.

Patches 1/3 (revision: clarify a 'return NULL' in get_reference()) and
2/3 (t6022: fix 'even though' typo in comment) are very small
preparatory cleanups.

Patch 3/3 (rev-list: add --allow-missing-tips to be used with
--missing=...) introduces the new `--allow-missing-tips` option that
allows git-rev-list(1) with `--missing` to not fail when one of the
tips it is passed is missing.

[1] https://lore.kernel.org/git/20231026101109.43110-1-karthik.188@gmail.com/

Christian Couder (3):
  revision: clarify a 'return NULL' in get_reference()
  t6022: fix 'even though' typo in comment
  rev-list: add --allow-missing-tips to be used with --missing=...

 builtin/rev-list.c          | 24 ++++++++++++++++-
 revision.c                  | 11 +++++---
 revision.h                  |  8 ++++++
 t/t6022-rev-list-missing.sh | 53 ++++++++++++++++++++++++++++++++++++-
 4 files changed, 90 insertions(+), 6 deletions(-)

-- 
2.43.0.496.gd667eb0d7d.dirty


             reply	other threads:[~2024-02-01 11:58 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-01 11:58 Christian Couder [this message]
2024-02-01 11:58 ` [PATCH 1/3] revision: clarify a 'return NULL' in get_reference() Christian Couder
2024-02-01 14:53   ` Eric Sunshine
2024-02-01 16:49     ` Christian Couder
2024-02-01 11:58 ` [PATCH 2/3] t6022: fix 'even though' typo in comment Christian Couder
2024-02-01 11:58 ` [PATCH 3/3] rev-list: add --allow-missing-tips to be used with --missing= Christian Couder
2024-02-01 20:20   ` Junio C Hamano
2024-02-02 11:29     ` Christian Couder
2024-02-02 16:47       ` Junio C Hamano
2024-02-01 21:27   ` Junio C Hamano
2024-02-02 11:29     ` Christian Couder
2024-02-02 16:54       ` Junio C Hamano
2024-02-07  9:57       ` Linus Arver
2024-02-07 16:34         ` Junio C Hamano
2024-02-07 16:38         ` Christian Couder
2024-02-07  9:40   ` Linus Arver
2024-02-07 16:11     ` Christian Couder
2024-02-07 20:48       ` Linus Arver
2024-02-08 15:03         ` Christian Couder
2024-02-08 20:42           ` Linus Arver

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240201115809.1177064-1-christian.couder@gmail.com \
    --to=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=johncai86@gmail.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).