From: Jeff King <peff@peff.net>
To: git@vger.kernel.org
Cc: Daniel Stenberg <daniel@haxx.se>
Subject: [PATCH 0/2] git+curl 8.7.0 workaround
Date: Tue, 2 Apr 2024 16:02:54 -0400 [thread overview]
Message-ID: <20240402200254.GA874754@coredump.intra.peff.net> (raw)
In-Reply-To: <2n7sn76-p413-5632-4o2s-o5n2p1rqnr5@unkk.fr>
On Sat, Mar 30, 2024 at 09:54:02AM +0100, Daniel Stenberg wrote:
> On Fri, 29 Mar 2024, Jeff King wrote:
>
> > I noticed some http-related failures in the test suite on my Debian
> > unstable system, which recently got an upgraded curl package. It looks
> > like it's related to cases where we use the remote-curl helper in
> > "connect" mode (i.e., protocol v2) and the http buffer is small
> > (requiring us to stream the data to curl). Besides just running t5551,
> > an easy reproduction is:
>
> This smells like a libcurl regression to me. I "imported" this into our
> issue tracker here: https://github.com/curl/curl/issues/13229
This was all resolved in that issue, but just to summarize for the list
here: it was a regression in curl and there's a fix already. Thanks
Daniel for your (as usual) prompt digging into the problem (and likewise
to Stefan for the actual fix).
Ultimately the issue will be fixed by moving to a different version of
libcurl, but here's an easy workaround in the meantime, with a small doc
cleanup I found along the way.
[1/2]: http: reset POSTFIELDSIZE when clearing curl handle
[2/2]: INSTALL: bump libcurl version to 7.21.3
INSTALL | 2 +-
http.c | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
-Peff
next prev parent reply other threads:[~2024-04-02 20:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-30 0:02 tests broken with curl-8.7.0 Jeff King
2024-03-30 8:54 ` Daniel Stenberg
2024-04-02 20:02 ` Jeff King [this message]
2024-04-02 20:05 ` [PATCH 1/2] http: reset POSTFIELDSIZE when clearing curl handle Jeff King
2024-04-02 20:27 ` Junio C Hamano
2024-04-03 3:20 ` Jeff King
2024-04-03 6:30 ` Patrick Steinhardt
2024-04-03 6:34 ` Patrick Steinhardt
2024-04-03 20:18 ` Jeff King
2024-04-02 20:06 ` [PATCH 2/2] INSTALL: bump libcurl version to 7.21.3 Jeff King
2024-04-02 20:21 ` [PATCH 0/2] git+curl 8.7.0 workaround rsbecker
2024-04-02 20:31 ` Jeff King
2024-04-05 20:04 ` [PATCH 3/2] remote-curl: add Transfer-Encoding header only for older curl Jeff King
2024-04-05 21:30 ` Daniel Stenberg
2024-04-05 21:49 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240402200254.GA874754@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=daniel@haxx.se \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).