git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: "Đoàn Trần Công Danh" <congdanhqx@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] t9604: Fix test for musl libc and new Debian
Date: Sat, 6 Apr 2024 21:33:12 -0400	[thread overview]
Message-ID: <20240407013312.GD1085004@coredump.intra.peff.net> (raw)
In-Reply-To: <23a4298eababe54ca4b43d7b675b858605d20ec5.1712374021.git.congdanhqx@gmail.com>

On Sat, Apr 06, 2024 at 10:29:10AM +0700, Đoàn Trần Công Danh wrote:

> CST6CDT and the like are POSIX timezone, with no rule for transition.
> And POSIX doesn't enforce how to interpret the rule if it's omited.
> Some libc resorted back to IANA (formerly Olson) db rules for those
> timezones.  Other libc (e.g. musl) interpret that as no transition at
> all [1].
> 
> In addition, distributions (notoriously Debian-derived, which uses IANA
> db for CST6CDT and the like) started to split "legacy" timezones
> like CST6CDT, EST5EDT into `tzdata-legacy', which will not be installed
> by default [2].
> 
> In those cases, t9604 will run into failure.
> 
> Let's switch to POSIX timezone with rules to change timezone.

This made me wonder if we are losing EST5, etc. We use that in t0006,
for example. But I guess not, since I do not have tzdata-legacy
installed (I am on Debian unstable) and haven't run into issues (I
didn't notice the cvsimport one because I lack other prereqs to run
those tests).

-Peff

  parent reply	other threads:[~2024-04-07  1:33 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-06  3:29 [PATCH] t9604: Fix test for musl libc and new Debian Đoàn Trần Công Danh
2024-04-06 12:11 ` Junio C Hamano
2024-04-07  1:38   ` Đoàn Trần Công Danh
2024-04-08 17:34     ` Junio C Hamano
2024-04-07  1:33 ` Jeff King [this message]
2024-04-07  1:45   ` Đoàn Trần Công Danh
2024-04-07  1:50     ` Đoàn Trần Công Danh
2024-04-10  3:28 ` [PATCH v2] " Đoàn Trần Công Danh
2024-04-10  3:29   ` Eric Sunshine
2024-04-10  3:35   ` Đoàn Trần Công Danh
2024-04-10  3:37   ` Eric Sunshine
2024-04-10  7:10     ` Đoàn Trần Công Danh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240407013312.GD1085004@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=congdanhqx@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).