git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Subject: [PATCH 0/2] give range-diff at the end of single patch output
Date: Thu, 23 May 2024 15:50:05 -0700	[thread overview]
Message-ID: <20240523225007.2871766-1-gitster@pobox.com> (raw)

When running "format-patch" on a multiple patch series, the output
coming from "--interdiff" and "--range-diff" options is inserted
after the "shortlog" list of commits and the overall diffstat.

The idea is that shortlog/diffstat are shorter and with denser
information content, which gives a better overview before the
readers dive into more details of range/inter diff.

When working on a single patch, however, we stuff the inter/range
diff output before the actual patch, next to the diffstat.  This
pushes down the patch text way down with inter/range diff output,
distracting readers.

Move the inter/range diff output to the very end of the output,
after all the patch text is shown.

The first patch is a no-op refactoring, the second patch makes the
actual behaviour change.

Junio C Hamano (2):
  show_log: factor out interdiff/range-diff generation
  format-patch: move range/inter diff at the end of a single patch
    output

 log-tree.c              | 89 ++++++++++++++++++++++-------------------
 t/t4014-format-patch.sh | 17 +++++---
 2 files changed, 59 insertions(+), 47 deletions(-)

-- 
2.45.1-246-gb9cfe4845c


             reply	other threads:[~2024-05-23 22:50 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-23 22:50 Junio C Hamano [this message]
2024-05-23 22:50 ` [PATCH 1/2] show_log: factor out interdiff/range-diff generation Junio C Hamano
2024-05-23 22:50 ` [PATCH 2/2] format-patch: move range/inter diff at the end of a single patch output Junio C Hamano
2024-05-24 11:14   ` Patrick Steinhardt
2024-05-24 21:46     ` Junio C Hamano
2024-05-27  5:19       ` Patrick Steinhardt
2024-05-27 12:59         ` Dragan Simic
2024-05-27 17:43         ` Junio C Hamano
2024-05-28 13:27           ` Patrick Steinhardt
2024-05-28 16:50             ` Junio C Hamano
2024-05-29  5:33               ` Patrick Steinhardt
2024-05-29 14:29                 ` Junio C Hamano
2024-05-30 20:05                   ` Dragan Simic
2024-05-24 23:02   ` [PATCH v2 " Junio C Hamano
2024-05-23 23:22 ` [PATCH 0/2] give range-diff at the end of " Dragan Simic
2024-05-23 23:25   ` Junio C Hamano
2024-05-23 23:35     ` Dragan Simic
2024-05-24  3:56       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240523225007.2871766-1-gitster@pobox.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).