From: Chandra Pratap <chandrapratap3519@gmail.com>
To: git@vger.kernel.org
Cc: Patrick Steinhardt <ps@pks.im>,
Christian Couder <chriscool@tuxfamily.org>,
Chandra Pratap <chandrapratap3519@gmail.com>
Subject: [GSoC][PATCH v3 0/4] t: port reftable/basics_test.c to the unit testing
Date: Wed, 29 May 2024 22:29:26 +0530 [thread overview]
Message-ID: <20240529171439.18271-1-chandrapratap3519@gmail.com> (raw)
In-Reply-To: <20240529070341.4248-1-chandrapratap3519@gmail.com>
In the recent codebase update (commit 8bf6fbd, 2023-12-09), a new unit
testing framework written entirely in C was introduced to the Git project
aimed at simplifying testing and reducing test run times.
Currently, tests for the reftable refs-backend are performed by a custom
testing framework defined by reftable/test_framework.{c, h}. Port
reftable/basics_test.c to the unit testing framework and improve upon
the ported test.
Mentored-by: Patrick Steinhardt <ps@pks.im>
Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Chandra Pratap <chandrapratap3519@gmail.com>
---
Changes in v3:
- Split up the 4th patch of the previous series into 2 sub-patches
CI/PR for v3: https://github.com/gitgitgadget/git/pull/1736
range-diff against v2:
1: 3ab1b415f4 = 1: 3ab1b415f4 t: move reftable/basics_test.c to the unit testing framework
2: 51fec8a376 = 2: 0143bbd2e4 t: move tests from reftable/stack_test.c to the new unit test
3: e0e9adfdf6 = 3: 2f1d02e945 t: move tests from reftable/record_test.c to the new unit test
-: ---------- > 4: 14606ac8db t: add test for put_be16()
4: 81b8975b4c ! 5: 2e741bab6d t: add test for put_be16() and improve test-case for parse_names()
@@ Metadata
Author: Chandra Pratap <chandrapratap3519@gmail.com>
## Commit message ##
- t: add test for put_be16() and improve test-case for parse_names()
+ t: improve the test-case for parse_names()
- put_be16() is a function defined in reftable/basics.{c, h} for which
- there are no tests in the current setup. Add a test for the same and
- improve the existing test-case for parse_names().
+ In the existing test-case for parse_names(), the fact that empty
+ lines should be ignored is not obvious because the empty line is
+ immediately followed by end-of-string. This can be mistaken as the
+ empty line getting replaced by NULL. Improve this by adding a
+ non-empty line after the empty one to demonstrate the intended behavior.
Mentored-by: Patrick Steinhardt <ps@pks.im>
Mentored-by: Christian Couder <chriscool@tuxfamily.org>
@@ t/unit-tests/t-reftable-basics.c: static void test_parse_names_normal(void)
free_names(out);
}
-@@ t/unit-tests/t-reftable-basics.c: static void test_common_prefix(void)
- strbuf_release(&b);
- }
-
--static void test_u24_roundtrip(void)
-+static void test_be_roundtrip(void)
- {
- uint32_t in = 0x112233;
- uint8_t dest[3];
- uint32_t out;
-+ /* test put_be24 and get_be24 roundtrip */
- put_be24(dest, in);
- out = get_be24(dest);
- check_int(in, ==, out);
-+ /* test put_be16 and get_be16 roundtrip */
-+ in = 0xfef1;
-+ put_be16(dest, in);
-+ out = get_be16(dest);
-+ check_int(in, ==, out);
- }
-
- int cmd_main(int argc, const char *argv[])
-@@ t/unit-tests/t-reftable-basics.c: int cmd_main(int argc, const char *argv[])
- TEST(test_binsearch(), "binary search with binsearch works");
- TEST(test_names_length(), "names_length retuns size of a NULL-terminated string array");
- TEST(test_names_equal(), "names_equal compares NULL-terminated string arrays");
-- TEST(test_u24_roundtrip(), "put_be24 and get_be24 work");
-+ TEST(test_be_roundtrip(), "put_be24, get_be24 and put_be16 work");
-
- return test_done();
- }
next prev parent reply other threads:[~2024-05-29 17:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <--in-reply-to=20240528113856.8348-1-chandrapratap3519@gmail.com>
2024-05-29 6:55 ` [GSoC][PATCH v2 0/4] t: port reftable/basics_test.c to the unit testing Chandra Pratap
2024-05-29 6:55 ` [GSoC][PATCH v2 1/4] t: move reftable/basics_test.c to the unit testing framework Chandra Pratap
2024-05-29 6:55 ` [GSoC][PATCH v2 2/4] t: move tests from reftable/stack_test.c to the new unit test Chandra Pratap
2024-05-29 6:55 ` [GSoC][PATCH v2 3/4] t: move tests from reftable/record_test.c " Chandra Pratap
2024-05-29 9:30 ` Patrick Steinhardt
2024-05-29 22:38 ` Junio C Hamano
2024-05-29 6:55 ` [GSoC][PATCH v2 4/4] t: add test for put_be16() and improve test-case for parse_names() Chandra Pratap
2024-05-29 9:30 ` Patrick Steinhardt
2024-05-29 9:29 ` [GSoC][PATCH v2 0/4] t: port reftable/basics_test.c to the unit testing Patrick Steinhardt
2024-05-29 16:59 ` Chandra Pratap [this message]
2024-05-29 16:59 ` [GSoC][PATCH v3 1/5] t: move reftable/basics_test.c to the unit testing framework Chandra Pratap
2024-05-29 16:59 ` [GSoC][PATCH v3 2/5] t: move tests from reftable/stack_test.c to the new unit test Chandra Pratap
2024-05-29 16:59 ` [GSoC][PATCH v3 3/5] t: move tests from reftable/record_test.c " Chandra Pratap
2024-05-29 16:59 ` [GSoC][PATCH v3 4/5] t: add test for put_be16() Chandra Pratap
2024-05-29 16:59 ` [GSoC][PATCH v3 5/5] t: improve the test-case for parse_names() Chandra Pratap
2024-05-30 4:35 ` [GSoC][PATCH v3 0/4] t: port reftable/basics_test.c to the unit testing Patrick Steinhardt
2024-05-30 7:52 ` Christian Couder
2024-05-30 14:33 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240529171439.18271-1-chandrapratap3519@gmail.com \
--to=chandrapratap3519@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).