From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Subject: [PATCH 0/4] varargs functions with __attributes__(())
Date: Sat, 8 Jun 2024 11:37:43 -0700 [thread overview]
Message-ID: <20240608183747.2084294-1-gitster@pobox.com> (raw)
There are several varargs functions that take either NULL-terminated
list of parameters, or printf-like format followed by list of
parameters, that are not declared as such with __attributes__(()).
Adding such a missing attribute to trace2_region_enter_printf()
revealed that an existing call to it was trying to format a value of
type size_t using "%d", which is not such an excellent idea. Other
functions that were lacking attributes fortunately did not have any
broken existing callers.
Junio C Hamano (4):
__attribute__: trace2_region_enter_printf() is like "printf"
__attribute__: remove redundant __attribute__ declaration for
git_die_config()
__attribute__: mark some functions with LAST_ARG_MUST_BE_NULL
__attribute__: add a few missing format attributes
add-patch.c | 1 +
attr.h | 2 ++
config.c | 1 -
hook.h | 1 +
mem-pool.h | 1 +
run-command.c | 3 ++-
scalar.c | 2 ++
trace2.h | 1 +
wt-status.c | 1 +
9 files changed, 11 insertions(+), 2 deletions(-)
--
2.45.2-445-g1b76f06508
next reply other threads:[~2024-06-08 18:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-08 18:37 Junio C Hamano [this message]
2024-06-08 18:37 ` [PATCH 1/4] __attribute__: trace2_region_enter_printf() is like "printf" Junio C Hamano
2024-06-10 7:01 ` Patrick Steinhardt
2024-06-10 16:15 ` Junio C Hamano
2024-06-08 18:37 ` [PATCH 2/4] __attribute__: remove redundant attribute declaration for git_die_config() Junio C Hamano
2024-06-08 18:37 ` [PATCH 3/4] __attribute__: mark some functions with LAST_ARG_MUST_BE_NULL Junio C Hamano
2024-06-08 18:37 ` [PATCH 4/4] __attribute__: add a few missing format attributes Junio C Hamano
2024-06-11 8:17 ` [PATCH 0/4] varargs functions with __attributes__(()) Jeff King
2024-06-11 15:17 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240608183747.2084294-1-gitster@pobox.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).