From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Subject: [PATCH 2/4] __attribute__: remove redundant attribute declaration for git_die_config()
Date: Sat, 8 Jun 2024 11:37:45 -0700 [thread overview]
Message-ID: <20240608183747.2084294-3-gitster@pobox.com> (raw)
In-Reply-To: <20240608183747.2084294-1-gitster@pobox.com>
The convention is to declare the function attribute to an extern
function together with its declaration in the header file, without
repeating the attribute declaration with its definition in the .c
source file (a file-scope static function declares its attribute
together with its definition in the .c file it is defined, as there
is no other place to do so).
The definition of git_die_config() in config.c did not follow the
convention and had its attribute declared with both its declaration
in the header and its definition in the .c source file.
Remove the one in the config.c to match everybody else.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
config.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/config.c b/config.c
index abce05b774..ea355f28ec 100644
--- a/config.c
+++ b/config.c
@@ -2844,7 +2844,6 @@ void git_die_config_linenr(const char *key, const char *filename, int linenr)
key, filename, linenr);
}
-NORETURN __attribute__((format(printf, 2, 3)))
void git_die_config(const char *key, const char *err, ...)
{
const struct string_list *values;
--
2.45.2-445-g1b76f06508
next prev parent reply other threads:[~2024-06-08 18:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-08 18:37 [PATCH 0/4] varargs functions with __attributes__(()) Junio C Hamano
2024-06-08 18:37 ` [PATCH 1/4] __attribute__: trace2_region_enter_printf() is like "printf" Junio C Hamano
2024-06-10 7:01 ` Patrick Steinhardt
2024-06-10 16:15 ` Junio C Hamano
2024-06-08 18:37 ` Junio C Hamano [this message]
2024-06-08 18:37 ` [PATCH 3/4] __attribute__: mark some functions with LAST_ARG_MUST_BE_NULL Junio C Hamano
2024-06-08 18:37 ` [PATCH 4/4] __attribute__: add a few missing format attributes Junio C Hamano
2024-06-11 8:17 ` [PATCH 0/4] varargs functions with __attributes__(()) Jeff King
2024-06-11 15:17 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240608183747.2084294-3-gitster@pobox.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).