From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Subject: [PATCH 4/4] __attribute__: add a few missing format attributes
Date: Sat, 8 Jun 2024 11:37:47 -0700 [thread overview]
Message-ID: <20240608183747.2084294-5-gitster@pobox.com> (raw)
In-Reply-To: <20240608183747.2084294-1-gitster@pobox.com>
A public function mem_pool_strfmt() takes printf like parameters,
but is not given an attribute as such. Also a few file-scope static
functions were missing their format attribute.
Add them.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
mem-pool.h | 1 +
scalar.c | 1 +
wt-status.c | 1 +
3 files changed, 3 insertions(+)
diff --git a/mem-pool.h b/mem-pool.h
index d1c66413ec..321d86a63c 100644
--- a/mem-pool.h
+++ b/mem-pool.h
@@ -50,6 +50,7 @@ char *mem_pool_strndup(struct mem_pool *pool, const char *str, size_t len);
/*
* Allocate memory from the memory pool and format a string into it.
*/
+__attribute__((format (printf, 2, 3)))
char *mem_pool_strfmt(struct mem_pool *pool, const char *fmt, ...);
/*
diff --git a/scalar.c b/scalar.c
index 62dd77aaec..a8318078c9 100644
--- a/scalar.c
+++ b/scalar.c
@@ -289,6 +289,7 @@ static int unregister_dir(void)
}
/* printf-style interface, expects `<key>=<value>` argument */
+__attribute__((format (printf, 1, 2)))
static int set_config(const char *fmt, ...)
{
struct strbuf buf = STRBUF_INIT;
diff --git a/wt-status.c b/wt-status.c
index ff4be071ca..c4dac01999 100644
--- a/wt-status.c
+++ b/wt-status.c
@@ -126,6 +126,7 @@ void status_printf(struct wt_status *s, const char *color,
va_end(ap);
}
+__attribute__((format (printf, 3, 4)))
static void status_printf_more(struct wt_status *s, const char *color,
const char *fmt, ...)
{
--
2.45.2-445-g1b76f06508
next prev parent reply other threads:[~2024-06-08 18:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-08 18:37 [PATCH 0/4] varargs functions with __attributes__(()) Junio C Hamano
2024-06-08 18:37 ` [PATCH 1/4] __attribute__: trace2_region_enter_printf() is like "printf" Junio C Hamano
2024-06-10 7:01 ` Patrick Steinhardt
2024-06-10 16:15 ` Junio C Hamano
2024-06-08 18:37 ` [PATCH 2/4] __attribute__: remove redundant attribute declaration for git_die_config() Junio C Hamano
2024-06-08 18:37 ` [PATCH 3/4] __attribute__: mark some functions with LAST_ARG_MUST_BE_NULL Junio C Hamano
2024-06-08 18:37 ` Junio C Hamano [this message]
2024-06-11 8:17 ` [PATCH 0/4] varargs functions with __attributes__(()) Jeff King
2024-06-11 15:17 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240608183747.2084294-5-gitster@pobox.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).