public inbox for git@vger.kernel.org
 help / color / mirror / Atom feed
From: Serhii Tereshchenko <serg.partizan@gmail.com>
To: git@vger.kernel.org
Cc: Serhii Tereshchenko <serg.partizan@gmail.com>
Subject: [PATCH] Fix default font scaling
Date: Sat, 15 Jun 2024 11:53:39 +0300	[thread overview]
Message-ID: <20240615085345.47278-1-serg.partizan@gmail.com> (raw)

This fixes font scaling for default fonts, where we don't set font
sizes explicitly.

Without this, on 4k monitor with text-scaling-factor configured in Gnome,
labels, buttons and settings are using very small font sizes. (Probably,
not just Gnome but anything that sets custom DPI).

Screenshots here: https://twiukraine.com/@partizan/112619567918546426

Signed-off-by: Serhii Tereshchenko <serg.partizan@gmail.com>
---
 git-gui.sh | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/git-gui.sh b/git-gui.sh
index 8bc8892..23dd82d 100755
--- a/git-gui.sh
+++ b/git-gui.sh
@@ -810,6 +810,16 @@ if {[is_Windows]} {
 ## config defaults
 
 set cursor_ptr arrow
+
+# For whatever reason, Tk does not apply font scaling to default fonts,
+# but applies font scaling when setting size explicitly.
+# Default -size 10 is still 10, when you look at it with `font actual ...`,
+# but explicitl -size 10 becomes 10 * scale factor.
+# So, we need to configure fonts to use their default font sizes, but scaled.
+foreach font_name [font names] {
+	font configure $font_name -size [font actual $font_name -size]
+}
+
 font create font_ui
 if {[lsearch -exact [font names] TkDefaultFont] != -1} {
 	eval [linsert [font actual TkDefaultFont] 0 font configure font_ui]
-- 
2.45.2


             reply	other threads:[~2024-06-15  8:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-15  8:53 Serhii Tereshchenko [this message]
2024-06-15 16:32 ` [PATCH] Fix default font scaling Eric Sunshine
2024-06-16 10:30 ` Johannes Sixt
2024-06-16 12:37   ` Serhii Tereshchenko
2024-06-20 17:24     ` Johannes Sixt
2024-06-20 18:11       ` Serhii Tereshchenko
2024-06-20 22:04         ` Johannes Sixt
2024-06-21  7:18           ` Serhii Tereshchenko
2024-06-23  9:13             ` Johannes Sixt
2024-06-23 10:11               ` serg.partizan
2024-06-23 14:00                 ` serg.partizan
2024-06-23 15:50                   ` Johannes Sixt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240615085345.47278-1-serg.partizan@gmail.com \
    --to=serg.partizan@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox