From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Subject: [PATCH 1/4] .gitignore: introduce GITIGNORE_FILE CPP macro
Date: Tue, 18 Jun 2024 16:44:32 -0700 [thread overview]
Message-ID: <20240618234436.4107855-2-gitster@pobox.com> (raw)
In-Reply-To: <20240618234436.4107855-1-gitster@pobox.com>
GITATTRIBUTES_FILE and GITMODULES_FILE have their own CPP macros
that resolve to their string literals to help compilers catch typos.
Add one for ".gitignore" as well.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
builtin/read-tree.c | 3 ++-
dir.c | 4 ++--
environment.h | 1 +
3 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/builtin/read-tree.c b/builtin/read-tree.c
index a8cf8504b8..bc12f5bd16 100644
--- a/builtin/read-tree.c
+++ b/builtin/read-tree.c
@@ -6,6 +6,7 @@
#include "builtin.h"
#include "config.h"
+#include "environment.h"
#include "gettext.h"
#include "hex.h"
#include "lockfile.h"
@@ -65,7 +66,7 @@ static int exclude_per_directory_cb(const struct option *opt, const char *arg,
if (!opts->update)
die("--exclude-per-directory is meaningless unless -u");
- if (strcmp(arg, ".gitignore"))
+ if (strcmp(arg, GITIGNORE_FILE))
die("--exclude-per-directory argument must be .gitignore");
return 0;
}
diff --git a/dir.c b/dir.c
index 45be4ad261..ec875e3878 100644
--- a/dir.c
+++ b/dir.c
@@ -2888,7 +2888,7 @@ static void new_untracked_cache(struct index_state *istate, int flags)
{
struct untracked_cache *uc = xcalloc(1, sizeof(*uc));
strbuf_init(&uc->ident, 100);
- uc->exclude_per_dir = ".gitignore";
+ uc->exclude_per_dir = GITIGNORE_FILE;
uc->dir_flags = flags >= 0 ? flags : new_untracked_cache_flags(istate);
set_untracked_ident(uc);
istate->untracked = uc;
@@ -3428,7 +3428,7 @@ static GIT_PATH_FUNC(git_path_info_exclude, "info/exclude")
void setup_standard_excludes(struct dir_struct *dir)
{
- dir->exclude_per_dir = ".gitignore";
+ dir->exclude_per_dir = GITIGNORE_FILE;
/* core.excludesfile defaulting to $XDG_CONFIG_HOME/git/ignore */
if (!excludes_file)
diff --git a/environment.h b/environment.h
index e9f01d4d11..39c3c24a3f 100644
--- a/environment.h
+++ b/environment.h
@@ -43,6 +43,7 @@ const char *getenv_safe(struct strvec *argv, const char *name);
#define GITMODULES_FILE ".gitmodules"
#define GITMODULES_INDEX ":.gitmodules"
#define GITMODULES_HEAD "HEAD:.gitmodules"
+#define GITIGNORE_FILE ".gitignore"
#define GIT_NOTES_REF_ENVIRONMENT "GIT_NOTES_REF"
#define GIT_NOTES_DEFAULT_REF "refs/notes/commits"
#define GIT_NOTES_DISPLAY_REF_ENVIRONMENT "GIT_NOTES_DISPLAY_REF"
--
2.45.2-711-gd2c001ca14
next prev parent reply other threads:[~2024-06-18 23:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 12:03 Non-blob .gitmodules and .gitattributes Alexey Pelykh
2024-06-14 15:35 ` Junio C Hamano
2024-06-14 15:43 ` Alexey Pelykh
2024-06-18 18:31 ` Jeff King
2024-06-18 19:07 ` Alexey Pelykh
2024-06-18 20:14 ` Junio C Hamano
2024-06-18 23:33 ` Jeff King
2024-06-18 23:44 ` [PATCH 0/4] .git{ignore,attributes} directories? Junio C Hamano
2024-06-18 23:44 ` Junio C Hamano [this message]
2024-06-18 23:44 ` [PATCH 2/4] attr: notice and report read failure of .gitattributes files Junio C Hamano
2024-06-19 0:21 ` Eric Sunshine
2024-06-19 1:18 ` Junio C Hamano
2024-06-19 2:35 ` Eric Sunshine
2024-06-19 13:57 ` Jeff King
2024-06-20 16:20 ` Junio C Hamano
2024-06-18 23:44 ` [PATCH 3/4] exclude: notice and report read failure of .gitignore files Junio C Hamano
2024-06-18 23:44 ` [PATCH 4/4] submodule: ignore .gitmodules that is not a regular file Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240618234436.4107855-2-gitster@pobox.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).