From: Chandra Pratap <chandrapratap3519@gmail.com>
To: git@vger.kernel.org
Cc: karthik188@gmail.com,
Chandra Pratap <chandrapratap3519@gmail.com>,
Patrick Steinhardt <ps@pks.im>,
Christian Couder <chriscool@tuxfamily.org>
Subject: [PATCH 07/11] t-reftable-record: add log tests for reftable_record_is_deletion()
Date: Fri, 21 Jun 2024 17:21:02 +0530 [thread overview]
Message-ID: <20240621115708.3626-8-chandrapratap3519@gmail.com> (raw)
In-Reply-To: <20240621115708.3626-1-chandrapratap3519@gmail.com>
reftable_record_is_deletion() is a function defined in
reftable/record.{c, h} that determines whether a record is of
type deletion or not. In the current testing setup, this function
is left untested for all the four record types (ref, log, obj, index).
Add tests for this function in the case of log records.
Mentored-by: Patrick Steinhardt <ps@pks.im>
Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Chandra Pratap <chandrapratap3519@gmail.com>
---
t/unit-tests/t-reftable-record.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/t/unit-tests/t-reftable-record.c b/t/unit-tests/t-reftable-record.c
index cbc2ce93b2..b2e1a892c0 100644
--- a/t/unit-tests/t-reftable-record.c
+++ b/t/unit-tests/t-reftable-record.c
@@ -231,6 +231,10 @@ static void test_reftable_log_record_roundtrip(void)
set_hash(in[2].value.update.new_hash, 3);
set_hash(in[2].value.update.old_hash, 4);
+ check(!reftable_log_record_is_deletion(&in[0]));
+ check(reftable_log_record_is_deletion(&in[1]));
+ check(!reftable_log_record_is_deletion(&in[2]));
+
for (size_t i = 0; i < ARRAY_SIZE(in); i++) {
struct reftable_record rec = { .type = BLOCK_TYPE_LOG };
struct strbuf key = STRBUF_INIT;
--
2.45.2.404.g9eaef5822c
next prev parent reply other threads:[~2024-06-21 11:58 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-21 5:46 [GSoC][PATCH 0/11] t: port reftable/record_test.c to the unit testing framework Chandra Pratap
2024-06-21 5:47 ` [PATCH 01/11] t: move " Chandra Pratap
2024-06-21 5:47 ` [PATCH 02/11] t-reftable-record: add reftable_record_cmp() tests for log records Chandra Pratap
2024-06-21 5:47 ` [PATCH 03/11] t-reftable-record: add comparison tests for ref records Chandra Pratap
2024-06-21 5:47 ` [PATCH 04/11] t-reftable-record: add comparison tests for index records Chandra Pratap
2024-06-21 5:47 ` [PATCH 05/11] t-reftable-record: add comparison tests for obj records Chandra Pratap
2024-06-21 5:47 ` [PATCH 06/11] t-reftable-record: add reftable_record_is_deletion() test for ref records Chandra Pratap
2024-06-21 5:47 ` [PATCH 07/11] t-reftable-record: add reftable_record_is_deletion() test for log records Chandra Pratap
2024-06-21 5:47 ` [PATCH 08/11] t-reftable-record: add reftable_record_is_deletion() test for obj records Chandra Pratap
2024-06-21 5:47 ` [PATCH 09/11] t-reftable-record: add reftable_record_is_deletion() test for index records Chandra Pratap
2024-06-21 5:47 ` [PATCH 10/11] t-reftable-record: add tests for reftable_ref_record_compare_name() Chandra Pratap
2024-06-21 5:47 ` [PATCH 11/11] t-reftable-record: add tests for reftable_log_record_compare_key() Chandra Pratap
2024-06-21 6:09 ` [GSoC][PATCH 0/11] t: port reftable/record_test.c to the unit testing framework Chandra Pratap
2024-06-21 11:50 ` Chandra Pratap
2024-06-21 11:50 ` [PATCH 01/11] t: move " Chandra Pratap
2024-06-25 8:26 ` Karthik Nayak
2024-06-25 13:12 ` Chandra Pratap
2024-06-26 11:52 ` Karthik Nayak
2024-06-26 12:57 ` Chandra Pratap
2024-06-26 14:24 ` Han-Wen Nienhuys
2024-06-21 11:50 ` [PATCH 02/11] t-reftable-record: add reftable_record_cmp() tests for log records Chandra Pratap
2024-06-25 8:36 ` Karthik Nayak
2024-06-21 11:50 ` [PATCH 03/11] t-reftable-record: add comparison tests for ref records Chandra Pratap
2024-06-21 11:50 ` [PATCH 04/11] t-reftable-record: add comparison tests for index records Chandra Pratap
2024-06-21 11:51 ` [PATCH 05/11] t-reftable-record: add comparison tests for obj records Chandra Pratap
2024-06-21 11:51 ` [PATCH 06/11] t-reftable-record: add ref tests for reftable_record_is_deletion() Chandra Pratap
2024-06-25 9:14 ` Karthik Nayak
2024-06-25 17:31 ` Eric Sunshine
2024-06-26 11:35 ` Karthik Nayak
2024-06-21 11:51 ` Chandra Pratap [this message]
2024-06-21 11:51 ` [PATCH 08/11] t-reftable-record: add obj " Chandra Pratap
2024-06-21 11:51 ` [PATCH 09/11] t-reftable-record: add index " Chandra Pratap
2024-06-25 9:19 ` Karthik Nayak
2024-06-25 14:11 ` Chandra Pratap
2024-06-26 11:59 ` Karthik Nayak
2024-06-21 11:51 ` [PATCH 10/11] t-reftable-record: add tests for reftable_ref_record_compare_name() Chandra Pratap
2024-06-25 9:26 ` Karthik Nayak
2024-06-25 13:45 ` Chandra Pratap
2024-06-21 11:51 ` [PATCH 11/11] t-reftable-record: add tests for reftable_log_record_compare_key() Chandra Pratap
2024-06-25 9:26 ` Karthik Nayak
2024-06-25 9:32 ` [GSoC][PATCH 0/11] t: port reftable/record_test.c to the unit testing framework Karthik Nayak
2024-06-28 6:19 ` [GSoC][PATCH v3 " Chandra Pratap
2024-06-28 6:19 ` [PATCH v3 01/11] t: move " Chandra Pratap
2024-06-30 16:24 ` Karthik Nayak
2024-06-28 6:19 ` [PATCH v3 02/11] t-reftable-record: add reftable_record_cmp() tests for log records Chandra Pratap
2024-06-28 6:19 ` [PATCH v3 03/11] t-reftable-record: add comparison tests for ref records Chandra Pratap
2024-06-28 6:19 ` [PATCH v3 04/11] t-reftable-record: add comparison tests for index records Chandra Pratap
2024-06-28 6:19 ` [PATCH v3 05/11] t-reftable-record: add comparison tests for obj records Chandra Pratap
2024-06-28 6:19 ` [PATCH v3 06/11] t-reftable-record: add ref tests for reftable_record_is_deletion() Chandra Pratap
2024-06-28 6:19 ` [PATCH v3 07/11] t-reftable-record: add log " Chandra Pratap
2024-06-28 6:19 ` [PATCH v3 08/11] t-reftable-record: add obj " Chandra Pratap
2024-06-28 6:19 ` [PATCH v3 09/11] t-reftable-record: add index " Chandra Pratap
2024-06-28 6:19 ` [PATCH v3 10/11] t-reftable-record: add tests for reftable_ref_record_compare_name() Chandra Pratap
2024-06-30 18:59 ` Karthik Nayak
2024-07-01 7:26 ` Chandra Pratap
2024-07-01 9:51 ` Karthik Nayak
2024-07-01 13:17 ` Chandra Pratap
2024-06-28 6:19 ` [PATCH v3 11/11] t-reftable-record: add tests for reftable_log_record_compare_key() Chandra Pratap
2024-06-30 19:11 ` Karthik Nayak
2024-06-30 19:12 ` [GSoC][PATCH v3 0/11] t: port reftable/record_test.c to the unit testing framework Karthik Nayak
2024-07-02 7:22 ` [GSoC][PATCH v4 0/11] t: port reftable/record_test.c to the unit testing framework framework Chandra Pratap
2024-07-02 7:22 ` [PATCH v4 01/11] t: move reftable/record_test.c to the unit testing framework Chandra Pratap
2024-07-02 7:22 ` [PATCH v4 02/11] t-reftable-record: add reftable_record_cmp() tests for log records Chandra Pratap
2024-07-02 7:22 ` [PATCH v4 03/11] t-reftable-record: add comparison tests for ref records Chandra Pratap
2024-07-02 7:22 ` [PATCH v4 04/11] t-reftable-record: add comparison tests for index records Chandra Pratap
2024-07-02 7:22 ` [PATCH v4 05/11] t-reftable-record: add comparison tests for obj records Chandra Pratap
2024-07-02 7:22 ` [PATCH v4 06/11] t-reftable-record: add ref tests for reftable_record_is_deletion() Chandra Pratap
2024-07-02 7:22 ` [PATCH v4 07/11] t-reftable-record: add log " Chandra Pratap
2024-07-02 7:22 ` [PATCH v4 08/11] t-reftable-record: add obj " Chandra Pratap
2024-07-02 7:22 ` [PATCH v4 09/11] t-reftable-record: add index " Chandra Pratap
2024-07-02 7:22 ` [PATCH v4 10/11] t-reftable-record: add tests for reftable_ref_record_compare_name() Chandra Pratap
2024-07-02 7:22 ` [PATCH v4 11/11] t-reftable-record: add tests for reftable_log_record_compare_key() Chandra Pratap
2024-07-02 10:55 ` [GSoC][PATCH v4 0/11] t: port reftable/record_test.c to the unit testing framework framework Karthik Nayak
2024-07-02 15:14 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240621115708.3626-8-chandrapratap3519@gmail.com \
--to=chandrapratap3519@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=karthik188@gmail.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).