From: Chandra Pratap <chandrapratap3519@gmail.com>
To: git@vger.kernel.org
Cc: chriscool@tuxfamily.org, karthik.188@gmail.com
Subject: [PATCH v2 3/7] t-reftable-merged: improve the test t_merged_single_record()
Date: Tue, 9 Jul 2024 10:58:42 +0530 [thread overview]
Message-ID: <20240709053847.4453-4-chandrapratap3519@gmail.com> (raw)
In-Reply-To: <20240709053847.4453-1-chandrapratap3519@gmail.com>
In t-reftable-merged.c, the test t_merged_single_record() ensures
that a ref ('a') which occurs in only one of the records ('r2')
can be retrieved. Improve this test by adding another record 'r3'
to ensure that ref 'a' only occurs in 'r2' and that merged tables
don't simply read the last record.
Mentored-by: Patrick Steinhardt <ps@pks.im>
Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Chandra Pratap <chandrapratap3519@gmail.com>
---
t/unit-tests/t-reftable-merged.c | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/t/unit-tests/t-reftable-merged.c b/t/unit-tests/t-reftable-merged.c
index a984116619..85ebb96aaa 100644
--- a/t/unit-tests/t-reftable-merged.c
+++ b/t/unit-tests/t-reftable-merged.c
@@ -136,14 +136,19 @@ static void t_merged_single_record(void)
.update_index = 2,
.value_type = REFTABLE_REF_DELETION,
} };
+ struct reftable_ref_record r3[] = { {
+ .refname = (char *) "c",
+ .update_index = 3,
+ .value_type = REFTABLE_REF_DELETION,
+ } };
- struct reftable_ref_record *refs[] = { r1, r2 };
- int sizes[] = { 1, 1 };
- struct strbuf bufs[2] = { STRBUF_INIT, STRBUF_INIT };
+ struct reftable_ref_record *refs[] = { r1, r2, r3 };
+ int sizes[] = { 1, 1, 1 };
+ struct strbuf bufs[3] = { STRBUF_INIT, STRBUF_INIT, STRBUF_INIT };
struct reftable_block_source *bs = NULL;
struct reftable_reader **readers = NULL;
struct reftable_merged_table *mt =
- merged_table_from_records(refs, &bs, &readers, sizes, bufs, 2);
+ merged_table_from_records(refs, &bs, &readers, sizes, bufs, 3);
struct reftable_ref_record ref = { 0 };
struct reftable_iterator it = { 0 };
int err;
@@ -157,7 +162,7 @@ static void t_merged_single_record(void)
check_int(ref.update_index, ==, 2);
reftable_ref_record_release(&ref);
reftable_iterator_destroy(&it);
- readers_destroy(readers, 2);
+ readers_destroy(readers, 3);
reftable_merged_table_free(mt);
for (size_t i = 0; i < ARRAY_SIZE(bufs); i++)
strbuf_release(&bufs[i]);
--
2.45.2.404.g9eaef5822c
next prev parent reply other threads:[~2024-07-09 5:39 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 17:01 [GSoC][PATCH 0/5] t: port reftable/merged_test.c to the unit testing framework Chandra Pratap
2024-07-03 17:01 ` [PATCH 1/5] t: move " Chandra Pratap
2024-07-05 17:40 ` Karthik Nayak
2024-07-06 7:13 ` Chandra Pratap
2024-07-03 17:01 ` [PATCH 2/5] t: harmonize t-reftable-merged.c with coding guidelines Chandra Pratap
2024-07-05 18:08 ` Karthik Nayak
2024-07-03 17:01 ` [PATCH 3/5] t-reftable-merged: add tests for reftable_merged_table_max_update_index Chandra Pratap
2024-07-03 17:01 ` [PATCH 4/5] t-reftable-merged: use reftable_ref_record_equal to compare ref records Chandra Pratap
2024-07-05 18:14 ` Karthik Nayak
2024-07-03 17:01 ` [PATCH 5/5] t-reftable-merged: add test for REFTABLE_FORMAT_ERROR Chandra Pratap
2024-07-05 18:24 ` [GSoC][PATCH 0/5] t: port reftable/merged_test.c to the unit testing framework Karthik Nayak
2024-07-09 5:28 ` [GSoC][PATCH v2 0/7] " Chandra Pratap
2024-07-09 5:28 ` [PATCH v2 1/7] t: move " Chandra Pratap
2024-07-09 23:05 ` Justin Tobler
2024-07-09 5:28 ` [PATCH v2 2/7] t: harmonize t-reftable-merged.c with coding guidelines Chandra Pratap
2024-07-09 5:28 ` Chandra Pratap [this message]
2024-07-09 5:28 ` [PATCH v2 4/7] t-reftable-merged: improve the const-correctness of helper functions Chandra Pratap
2024-07-09 5:28 ` [PATCH v2 5/7] t-reftable-merged: add tests for reftable_merged_table_max_update_index Chandra Pratap
2024-07-09 5:28 ` [PATCH v2 6/7] t-reftable-merged: use reftable_ref_record_equal to compare ref records Chandra Pratap
2024-07-09 5:28 ` [PATCH v2 7/7] t-reftable-merged: add test for REFTABLE_FORMAT_ERROR Chandra Pratap
2024-07-10 9:18 ` Karthik Nayak
2024-07-10 9:19 ` [GSoC][PATCH v2 0/7] t: port reftable/merged_test.c to the unit testing framework Karthik Nayak
2024-07-11 14:38 ` Junio C Hamano
2024-07-11 3:58 ` [GSoC][PATCH v3 " Chandra Pratap
2024-07-11 3:58 ` [PATCH v3 1/7] t: move " Chandra Pratap
2024-07-11 3:58 ` [PATCH v3 2/7] t: harmonize t-reftable-merged.c with coding guidelines Chandra Pratap
2024-07-11 20:38 ` Junio C Hamano
2024-07-11 3:58 ` [PATCH v3 3/7] t-reftable-merged: improve the test t_merged_single_record() Chandra Pratap
2024-07-11 3:58 ` [PATCH v3 4/7] t-reftable-merged: improve the const-correctness of helper functions Chandra Pratap
2024-07-11 3:58 ` [PATCH v3 5/7] t-reftable-merged: add tests for reftable_merged_table_max_update_index Chandra Pratap
2024-07-11 3:58 ` [PATCH v3 6/7] t-reftable-merged: use reftable_ref_record_equal to compare ref records Chandra Pratap
2024-07-11 3:58 ` [PATCH v3 7/7] t-reftable-merged: add test for REFTABLE_FORMAT_ERROR Chandra Pratap
2024-07-12 5:38 ` [GSoC][PATCH v4 0/7] t: port reftable/merged_test.c to the unit testing framework Chandra Pratap
2024-07-12 5:38 ` [PATCH v4 1/7] t: move " Chandra Pratap
2024-07-12 5:38 ` [PATCH v4 2/7] t: harmonize t-reftable-merged.c with coding guidelines Chandra Pratap
2024-07-12 5:38 ` [PATCH v4 3/7] t-reftable-merged: improve the test t_merged_single_record() Chandra Pratap
2024-07-12 5:39 ` [PATCH v4 4/7] t-reftable-merged: improve the const-correctness of helper functions Chandra Pratap
2024-07-24 9:12 ` Patrick Steinhardt
2024-07-12 5:39 ` [PATCH v4 5/7] t-reftable-merged: add tests for reftable_merged_table_max_update_index Chandra Pratap
2024-07-12 5:39 ` [PATCH v4 6/7] t-reftable-merged: use reftable_ref_record_equal to compare ref records Chandra Pratap
2024-07-12 5:39 ` [PATCH v4 7/7] t-reftable-merged: add test for REFTABLE_FORMAT_ERROR Chandra Pratap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240709053847.4453-4-chandrapratap3519@gmail.com \
--to=chandrapratap3519@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=karthik.188@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).